Create ManagementContract #2119

erikzhang · 2020-12-04T09:14:57Z

Created a new native contract, ManagementContract, to manage all the contracts.
Native contracts can be deployed in any block. The ManagementContract will check their ActiveBlockIndex field.
Moved Contract.Create, Contract.Update, and Contract.Destroy to the native contract as methods.
Moved ContractState and ContractIdState to the native contract as storage entries.

Close #2000
Close #2056

erikzhang · 2020-12-04T09:15:27Z

@shargon @roman-khimov

shargon · 2020-12-04T09:31:32Z

I will fix the UT

erikzhang · 2020-12-04T09:33:14Z

I will fix the UT

Please wait for me to complete the TODOs.

Do you think this direction is okay?

shargon · 2020-12-04T09:35:37Z

Do you think this direction is okay?

I think that it's simpler, the deploy method it was faster in the previous version, but as roman said in the meeting, the cost deserve because it's simpler.

roman-khimov · 2020-12-04T09:52:47Z

Yeah, it's good.

src/neo/SmartContract/Native/ManagementContract.cs

erikzhang · 2020-12-04T12:20:09Z

Ready to review. @shargon Please fix the UTs.

src/neo/SmartContract/Native/ManagementContract.cs

erikzhang · 2020-12-05T13:07:14Z

@neo-project/ngd-shanghai Can you test it?

src/neo/SmartContract/Native/ManagementContract.cs

superboyiii · 2020-12-09T02:31:36Z

Why native contracts don't include upgrade method? @erikzhang @shargon

erikzhang · 2020-12-09T03:28:21Z

Because they are native, they have magic. 🤣

superboyiii · 2020-12-09T04:05:47Z

Because they are native, they have magic. 🤣

If we include upgrade method in native contract now, then they could avoid storage conflict after upgrading, especially when we resync the histroy data in a new version.

PS: I found it still can't solve this. Upgrade method is not necessary in native SC. 🤣

shargon · 2020-12-09T04:11:03Z

We can include upgrade later, if it's necessary

* Sync to neo-project/neo#2119 * Update nuget Co-authored-by: Shargon <shargon@gmail.com>

Every contract now has these and they're always invoked. See neo-project/neo#1913 and neo-project/neo#2119.

See neo-project/neo#2119.

Follow neo-project/neo#2119 changes.

See neo-project/neo#2119.

Follow neo-project/neo#2119 changes.

* Sync to management SC (#689) * Sync to neo-project/neo#2119 * Update nuget Co-authored-by: Shargon <shargon@gmail.com> * Update to Neo v3.0.0-CI01105 (#692) * Update to Neo v3.0.0-CI01015 * Update neo-cli.csproj Co-authored-by: Shargon <shargon@gmail.com>

* Sync to management SC (#689) * Sync to neo-project/neo#2119 * Update nuget Co-authored-by: Shargon <shargon@gmail.com> * Update to Neo v3.0.0-CI01105 (#692) * Update to Neo v3.0.0-CI01015 * Update neo-cli.csproj * Update name nep17 (#695) * Fix Parse manifestFilePath * merge master * Update Name for NEP17 * fix format * show error message * fix * fix Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: cloud8little <34291844+cloud8little@users.noreply.github.com>

* Final merge for Preview4 (#693) * Sync to management SC (#689) * Sync to neo-project/neo#2119 * Update nuget Co-authored-by: Shargon <shargon@gmail.com> * Update to Neo v3.0.0-CI01105 (#692) * Update to Neo v3.0.0-CI01015 * Update neo-cli.csproj Co-authored-by: Shargon <shargon@gmail.com> * Merge from master (#697) * Sync to management SC (#689) * Sync to neo-project/neo#2119 * Update nuget Co-authored-by: Shargon <shargon@gmail.com> * Update to Neo v3.0.0-CI01105 (#692) * Update to Neo v3.0.0-CI01015 * Update neo-cli.csproj * Update name nep17 (#695) * Fix Parse manifestFilePath * merge master * Update Name for NEP17 * fix format * show error message * fix * fix Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: cloud8little <34291844+cloud8little@users.noreply.github.com> * Preview4 * sync gui * update changelog for preview 4 (#699) Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: cloud8little <34291844+cloud8little@users.noreply.github.com> Co-authored-by: Qiao Jin <43407364+Qiao-Jin@users.noreply.github.com>

utterly broken after this but not fixing until all preview + preview 5 changes are in

Create ManagementContract

e69d746

erikzhang requested a review from shargon December 4, 2020 09:14

erikzhang mentioned this pull request Dec 4, 2020

Allow deploy native contracts in any block (only once) #2056

Closed

erikzhang added 2 commits December 4, 2020 18:15

Move contract management SYSCALLs to native

d6de55e

Move ContractIdState to native contract storage

6abf0e7

vncoelho reviewed Dec 4, 2020

View reviewed changes

src/neo/SmartContract/Native/ManagementContract.cs Show resolved Hide resolved

vncoelho reviewed Dec 4, 2020

View reviewed changes

src/neo/SmartContract/Native/ManagementContract.cs Show resolved Hide resolved

Move ContractState to native contract storage

f91fc0e

erikzhang added this to the NEO 3.0 milestone Dec 4, 2020

Fix some issues

b097850

erikzhang commented Dec 4, 2020

View reviewed changes

src/neo/SmartContract/Native/ManagementContract.cs Outdated Show resolved Hide resolved

shargon added 11 commits December 4, 2020 16:49

Fix more ut

6fb8787

Fix some compilation errors

970dd3a

Some UT fixes

8b8a30f

Fix some UT

3e82595

Some UT fixes

538ddf7

More fixes

6fef235

Fix more UT

d7e1ffa

Fix NeoToken UT

173c0c0

Fix update UT

681218e

Fix destroy

6eb443e

Fix UT

a040eeb

Tommo-L reviewed Dec 7, 2020

View reviewed changes

src/neo/SmartContract/Native/ManagementContract.cs Outdated Show resolved Hide resolved

shargon approved these changes Dec 9, 2020

View reviewed changes

superboyiii approved these changes Dec 9, 2020

View reviewed changes

erikzhang merged commit beac9a9 into master Dec 9, 2020

erikzhang deleted the management-contract branch December 9, 2020 04:40

roman-khimov mentioned this pull request Dec 9, 2020

OnPersist semantics for native contracts #1913

Closed

superboyiii added a commit to neo-project/neo-node that referenced this pull request Dec 10, 2020

Sync to management SC (#689)

44ca8f5

* Sync to neo-project/neo#2119 * Update nuget Co-authored-by: Shargon <shargon@gmail.com>

This was referenced Dec 10, 2020

Specifying NativeContract ActiveBlockIndex in code will be an issue for privatenets #2131

Closed

ManagementContract Support neo-project/neo-express#91

Merged

mialbu mentioned this pull request Dec 10, 2020

Implement ManagementContract wrapper class neow3j/neow3j#310

Closed

roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Dec 13, 2020

native: change OnPersist/PostPersist handling

090bee8

Every contract now has these and they're always invoked. See neo-project/neo#1913 and neo-project/neo#2119.

roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Dec 13, 2020

native: move contract deployment to management contract

215fd2b

See neo-project/neo#2119.

roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Dec 13, 2020

native: move contract deployment to management contract

fa5437b

See neo-project/neo#2119.

roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Dec 14, 2020

native: move contract deployment to management contract

b1d5e3c

See neo-project/neo#2119.

roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Dec 14, 2020

nef: lower MaxScriptLength

24d6966

Follow neo-project/neo#2119 changes.

roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Dec 14, 2020

nef: lower MaxScriptLength

7e3a9bf

Follow neo-project/neo#2119 changes.

roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Dec 14, 2020

native: move contract deployment to management contract

ab12eee

See neo-project/neo#2119.

roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Dec 14, 2020

nef: lower MaxScriptLength

2e0fe37

Follow neo-project/neo#2119 changes.

danwbyrne mentioned this pull request Dec 18, 2020

Update to Neo3-preview4 neo-one-suite/neo-one#2267

Closed

45 tasks

roman-khimov mentioned this pull request Dec 25, 2020

Contract state problem #2181

Closed

danwbyrne mentioned this pull request Dec 29, 2020

Update NativeContract models for Preview4 changes neo-one-suite/neo-one#2273

Closed

17 tasks

ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021

Create ManagementContract (neo-project#2119)

8ef0f69

cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021

Create ManagementContract (neo-project#2119)

e59cf38

ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Feb 2, 2021

https://github.com/neo-project/neo/pull/2119

5d9c730

utterly broken after this but not fixing until all preview + preview 5 changes are in

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create ManagementContract #2119

Create ManagementContract #2119

erikzhang commented Dec 4, 2020 •

edited

Loading

erikzhang commented Dec 4, 2020

shargon commented Dec 4, 2020

erikzhang commented Dec 4, 2020

shargon commented Dec 4, 2020 •

edited

Loading

roman-khimov commented Dec 4, 2020

erikzhang commented Dec 4, 2020

erikzhang commented Dec 5, 2020

superboyiii commented Dec 9, 2020

erikzhang commented Dec 9, 2020

superboyiii commented Dec 9, 2020 •

edited

Loading

shargon commented Dec 9, 2020

Create ManagementContract #2119

Create ManagementContract #2119

Conversation

erikzhang commented Dec 4, 2020 • edited Loading

erikzhang commented Dec 4, 2020

shargon commented Dec 4, 2020

erikzhang commented Dec 4, 2020

shargon commented Dec 4, 2020 • edited Loading

roman-khimov commented Dec 4, 2020

erikzhang commented Dec 4, 2020

erikzhang commented Dec 5, 2020

superboyiii commented Dec 9, 2020

erikzhang commented Dec 9, 2020

superboyiii commented Dec 9, 2020 • edited Loading

shargon commented Dec 9, 2020

erikzhang commented Dec 4, 2020 •

edited

Loading

shargon commented Dec 4, 2020 •

edited

Loading

superboyiii commented Dec 9, 2020 •

edited

Loading