Random implementation #2481
Closed
Random implementation #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think it still allows Primary to pre-execute transactions and see how the last block hash affects random number generated and then choose some combination that benefits Primary for some reason. And it also still can generate/insert transaction of its own to see if it allows to win the lottery.
| } | ||
|
|
||
| // Double Sha256 | ||
| return BitConverter.ToUInt64(hash.Sha256().Sha256()); |
There was a problem hiding this comment.
One hash is enough maybe?
Jim8y
reviewed
May 25, 2021
| @@ -133,7 +133,8 @@ protected internal ulong GetRandom() | |||
| // Block related | |||
| for (int count = 0; count < ProtocolSettings.ValidatorsCount; index--, count++) | |||
| { | |||
| System.Array.Copy(NativeContract.Ledger.GetBlockHash(Snapshot, index).ToArray(), 0, hash, offset + (UInt256.Length * count), UInt256.Length); | |||
| var blockHash = count == 0 ? PersistingBlock.Hash : NativeContract.Ledger.GetBlockHash(Snapshot, index); | |||
There was a problem hiding this comment.
PersistingBlock.Hash is decidable to the primary, this makes the random number not unique.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #2477 without consensus changes