Allow Log in Safe methods

[shargon]

Close #2782

[roman-khimov]

From a purist POV safe methods are supposed to be free of any side-effects and logging is a side-effect. But practically #2782 is a problem and I don't see how this could be misused, so probably it's OK to allow logging in safe methods.

[erikzhang]

From a purist POV safe methods are supposed to be free of any side-effects and logging is a side-effect.

I agree.

[shargon]

Log's side-effects depend on the plugin that uses it, because the core itself doesn't do it, so it's safe, until it stops being safe for a third party, which would be the third party's problem, I understand what you're saying but the the problem with not changing it is making error handling in Safe methods unusable.

Any alternative?

[erikzhang]

Any alternative?

throw.

[shargon]

But Throw it's catcheable, different than Assert

[erikzhang]

But Throw it's catcheable, different than Assert

Safe method has no side effects, so it doesn't matter if it is caught, right?

[shargon]

But Throw it's catcheable, different than Assert

Safe method has no side effects, so it doesn't matter if it is caught, right?

It matter because the developer expect to end the execution, so undesired results may happen

[erikzhang]

It matter because the developer expect to end the execution, so undesired results may happen

It's a safe method. It doesn't matter if the execution is ended or not.