Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check null scriptcontainer #2953

Merged
merged 3 commits into from
Nov 9, 2023
Merged

check null scriptcontainer #2953

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98adfb4
check null scriptcontainer
Jim8y Nov 9, 2023
f68ca54
Clean code
shargon Nov 9, 2023
40ed6ee
Add comment
shargon Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Neo/SmartContract/ApplicationEngine.Runtime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,11 @@ protected internal bool CheckWitnessInternal(UInt160 hash)
}
return false;
}
else
Copy link
Contributor Author

@Jim8y Jim8y Nov 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code looks so weird, do we need this else here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It reduces one condition in the positive case (the usual one)

{
// If we don't have the ScriptContainer, we consider that there are no script hashes for verifying
if (ScriptContainer is null) return false;
shargon marked this conversation as resolved.
Show resolved Hide resolved
shargon marked this conversation as resolved.
Show resolved Hide resolved
}

// Check allow state callflag

Expand Down