Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement native Notary contract #3178

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Implement native Notary contract #3178

wants to merge 30 commits into from

Commits on Mar 6, 2024

  1. Implement NotaryAssisted transaction attribute 

    Close #2896. Use a stub for native Notary contract hash since this
contract is not implemented yet. Thus, technically, NotaryAssisted
attribute verification will always fail on real network until native
Notary is implemented.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
    @AnnaShaleva
    AnnaShaleva committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    6da4ae2 View commit details
    Browse the repository at this point in the history

  2. Payloads: add doc to CalculateNetworkFee method of NotaryAssisted att… 

    …ribute

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
    @AnnaShaleva
    AnnaShaleva committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    acec1b0 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Native: add NotaryAssisted attributes handler to Gas OnPersist 

    Transactions network fee should be split between Primary node and Notary
nodes.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
    @AnnaShaleva
    AnnaShaleva committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    1508d4f View commit details
    Browse the repository at this point in the history

  2. Payloads: adjust comment to NotaryAssisted attribute 

    Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
    @AnnaShaleva
    AnnaShaleva committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    8b547c9 View commit details
    Browse the repository at this point in the history

  3. Payloads: temporary use hard-coded Notary contract hash 

    Once Notary contract is implemented, this hash will be replaced by a
proper Notary contract hash. The exact value won't be changed since
Notary contract has constant hash as any other native contract.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
    @AnnaShaleva
    AnnaShaleva committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    b16a28c View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Merge branch 'master' into notary-assisted

    @Jim8y
    Jim8y committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    00b54ff View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Payloads: replace hard-coded Notary hash value with calculated one 

    No functional changes, just a refactoring for better code readability.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
    @AnnaShaleva
    AnnaShaleva committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    24135ff View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Native: implement native Notary contract 

    Close #2897. Depends on #3175.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
    @AnnaShaleva
    AnnaShaleva committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    77ffe09 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Native: fix typo in the exception message 

    Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
    @AnnaShaleva
    AnnaShaleva committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    cb4bdda View commit details
    Browse the repository at this point in the history

  2. Native: use more syntactic sugar 

    No functional changes, just a refactoring.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
    @AnnaShaleva
    AnnaShaleva committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    8f9f5f7 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Merge branch 'master' into notary-contract

    @Jim8y
    Jim8y committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    5ee1855 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Notary: add unit tests for OnNEP17Payment and ExpirationOf methods 

    Also, mark improper code of Withdraw method with TODO, it should be
reworked.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
    @AnnaShaleva
    AnnaShaleva committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    02c6a89 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Fix transfer

    @shargon
    shargon committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    21f5fcf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into notary-contract

    @shargon
    shargon committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    af4a87a View commit details
    Browse the repository at this point in the history

  3. Update tests/Neo.UnitTests/SmartContract/Native/UT_Notary.cs

    @shargon
    shargon committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    e8d384e View commit details
    Browse the repository at this point in the history

  4. Update UT_Notary.cs

    @shargon
    shargon committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    26c9430 View commit details
    Browse the repository at this point in the history

  5. fix

    @shargon
    shargon committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    b23859f View commit details
    Browse the repository at this point in the history

  6. Merge branch 'notary-contract' of https://github.com/neo-project/neo … 

    …into notary-contract
    @shargon
    shargon committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    ecfba77 View commit details
    Browse the repository at this point in the history

  7. Fix notary

    @shargon
    shargon committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    ff03214 View commit details
    Browse the repository at this point in the history

  8. Fix notary

    @shargon
    shargon committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    adf0bb0 View commit details
    Browse the repository at this point in the history

  9. Notary: add unit tests for LockDepositUntil and BalanceOf methods 

    Also, format code.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
    @AnnaShaleva
    AnnaShaleva committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    08da1f0 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Merge branch 'master' into notary-contract

    @AnnaShaleva
    AnnaShaleva committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    f7924ca View commit details
    Browse the repository at this point in the history

  2. Notary: test GAS distribution with FeePerKey update 

    Test the situation described in
https://github.com/neo-project/neo/pull/3175/files/00b54ff6d20cc84b435beaa790fe72a9d8f78bec#r1530493475.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
    @AnnaShaleva
    AnnaShaleva committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    6705469 View commit details
    Browse the repository at this point in the history

  3. Notary: add test for Withdraw 

    Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
    @AnnaShaleva
    AnnaShaleva committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    8864ff5 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Notary: remove unused code 

    No functional changes, I just finally made my code analizer work
properly.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
    @AnnaShaleva
    AnnaShaleva committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    498f2ff View commit details
    Browse the repository at this point in the history

  2. Attributtes: fix NotaryAssisted attribute documentation format 

    Co-authored-by: Shargon <shargon@gmail.com>
    @AnnaShaleva @shargon
    AnnaShaleva and shargon committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    efa9958 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into notary-contract

    @cschuchardt88
    cschuchardt88 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    dd0b965 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Merge branch 'master' into notary-contract

    @cschuchardt88
    cschuchardt88 committed May 23, 2024
    Configuration menu
    Copy the full SHA
    f6cbd36 View commit details
    Browse the repository at this point in the history

  2. Native: update to the fresh master 

    Fetch changes from the fresh master and fix build errors.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
    @AnnaShaleva
    AnnaShaleva committed May 23, 2024
    Configuration menu
    Copy the full SHA
    deafea9 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Merge branch 'master' into notary-contract

    @shargon
    shargon committed May 24, 2024
    Configuration menu
    Copy the full SHA
    2f1d38c View commit details
    Browse the repository at this point in the history