New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass ApplicationExecution to IPersistencePlugin #531

Merged
merged 11 commits into from Jan 1, 2019

Conversation

5 participants
@spclight
Copy link
Contributor

spclight commented Dec 28, 2018

This PR resolves #480 .

SwitchyTheCoder added some commits Dec 26, 2018

Pass ApplicationExecutionResult to IPersistencePlugin (#1)
* Pass ApplicationExecutionResult to IPersistencePlugin

* Remove ToArray()
@@ -455,6 +455,7 @@ private void Persist(Block block)
{
using (Snapshot snapshot = GetSnapshot())
{
List<ApplicationExecuted> all_application_executed = new List<ApplicationExecuted>();

This comment has been minimized.

@jsolman

jsolman Dec 30, 2018

Contributor

I know there already isn’t consistency, but I think it is better if we start adopting camel case instead of underscores in the variable naming convention.

@erikzhang erikzhang merged commit c0f1500 into neo-project:master Jan 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment