Use akka.net EventStream #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sounds good, @erikzhang, EventStream looks like to be a simple and common way for communication with an |
vncoelho
approved these changes
Mar 7, 2019
vncoelho
reviewed
Mar 7, 2019
| @@ -628,7 +606,7 @@ private void Persist(Block block) | |||
| Transaction = tx, | |||
| ExecutionResults = execution_results.ToArray() | |||
| }; | |||
| Distribute(application_executed); | |||
| Context.System.EventStream.Publish(application_executed); | |||
There was a problem hiding this comment.
Just a minor thing, the type that was set was PersistedCompleted, will it also listen to ApplicationExecuted?
There was a problem hiding this comment.
Thus, who go this message Context.System.EventStream.Publish(application_executed);?
igormcoelho
reviewed
Mar 8, 2019
| @@ -46,6 +46,7 @@ public ConsensusService(IActorRef localNode, IActorRef taskManager, Store store, | |||
| this.taskManager = taskManager; | |||
| this.store = store; | |||
| this.context = context; | |||
| Context.System.EventStream.Subscribe(Self, typeof(Blockchain.PersistCompleted)); | |||
There was a problem hiding this comment.
Perhaps I'll need to update Unit tests for this Erik... I remember that TesKit also had an EventStream system. Perhaps another method on IConsensuContext, I don't know yet... I'll study more, let's see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.