Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests for All Mailboxes (Neo 2.x) #821

Merged
merged 4 commits into from Jun 12, 2019

Conversation

igormcoelho
Copy link
Contributor

Ricardo, this may help your testings.

@igormcoelho
Copy link
Contributor Author

Ok @shargon, now this is the full package for Neo 2.x hahaha Do you think is there anything else testable in this context? I tried all possibilities.

Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, we should improve unit tests only for neo 3

Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job, brother

@vncoelho vncoelho merged commit 1e2c6c6 into neo-project:master-2.x Jun 12, 2019
@vncoelho vncoelho deleted the test_2x_all_mailboxes branch June 12, 2019 20:11
@igormcoelho
Copy link
Contributor Author

igormcoelho commented Jun 12, 2019

In the future, we should improve unit tests only for neo 3

These tests are specifically necessary to help fixing existing bugs on Neo 2 LTS

@vncoelho
Copy link
Member

exactly

@vncoelho vncoelho added the port-to-3.x Feature or PR must be ported to Neo 3.x branch label Jun 12, 2019
@igormcoelho
Copy link
Contributor Author

igormcoelho commented Jun 12, 2019

But I agree with you @shargon, focus is on Neo 3. It's hard to keep doing everything twice...

@igormcoelho igormcoelho removed the port-to-3.x Feature or PR must be ported to Neo 3.x branch label Jun 12, 2019
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants