Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests for All Mailboxes (Neo 2.x) #821

Merged
merged 4 commits into from Jun 12, 2019

Conversation

3 participants
@igormcoelho
Copy link
Contributor

commented Jun 12, 2019

Ricardo, this may help your testings.

igormcoelho added some commits Jun 12, 2019

@igormcoelho igormcoelho requested review from shargon and vncoelho Jun 12, 2019

@igormcoelho

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Ok @shargon, now this is the full package for Neo 2.x hahaha Do you think is there anything else testable in this context? I tried all possibilities.

@shargon
Copy link
Member

left a comment

In the future, we should improve unit tests only for neo 3

@vncoelho
Copy link
Member

left a comment

great job, brother

@vncoelho vncoelho merged commit 1e2c6c6 into neo-project:master-2.x Jun 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vncoelho vncoelho deleted the igormcoelho:test_2x_all_mailboxes branch Jun 12, 2019

@igormcoelho

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

In the future, we should improve unit tests only for neo 3

These tests are specifically necessary to help fixing existing bugs on Neo 2 LTS

@vncoelho

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

exactly

@igormcoelho

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

But I agree with you @shargon, focus is on Neo 3. It's hard to keep doing everything twice...

KickSeason added a commit to KickSeason/neo that referenced this pull request Jun 13, 2019

Merge pull request #1 from neo-project/master-2.x
Unit Tests for All Mailboxes (Neo 2.x) (neo-project#821)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.