Json NEP6Wallet with basic tests #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #847 +/- ##
=========================================
+ Coverage 38.45% 38.7% +0.24%
=========================================
Files 176 176
Lines 12474 12482 +8
=========================================
+ Hits 4797 4831 +34
+ Misses 7677 7651 -26
Continue to review full report at Codecov.
|
|
@erikzhang I need a small help here... do you know why second test is giving null for ScryptParameters inside NEP6Wallet? |
|
Nevermind, all tests passed now!! \o/ |
shargon
previously approved these changes
Jun 21, 2019
shargon
approved these changes
Jun 21, 2019
|
@vncoelho json wallet, fine for you? |
vncoelho
approved these changes
Jun 21, 2019
Thacryba
pushed a commit
to simplitech/neo
that referenced
this pull request
Feb 17, 2020
Tommo-L
pushed a commit
to Tommo-L/neo
that referenced
this pull request
Jun 22, 2020
* Json NEP6Wallet with basic tests * Scrypt is null, why * testing ScryptParameters * ScryptParameters not null, then null, why * string is correct, still null * shouldnt be null * correctly using out for readonly * reading from json * format * Scrypt to lowercase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may help you @shargon on #791