Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json NEP6Wallet with basic tests #847

Merged

Conversation

5 participants
@igormcoelho
Copy link
Contributor

commented Jun 20, 2019

This may help you @shargon on #791

igormcoelho added some commits Jun 20, 2019

@igormcoelho igormcoelho requested a review from shargon Jun 20, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jun 20, 2019

Codecov Report

Merging #847 into master will increase coverage by 0.24%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #847      +/-   ##
=========================================
+ Coverage   38.45%   38.7%   +0.24%     
=========================================
  Files         176     176              
  Lines       12474   12482       +8     
=========================================
+ Hits         4797    4831      +34     
+ Misses       7677    7651      -26
Impacted Files Coverage Δ
neo/Wallets/NEP6/NEP6Wallet.cs 6.19% <92.3%> (+6.19%) ⬆️
neo/IO/Json/JArray.cs 61.7% <0%> (+3.19%) ⬆️
neo/Wallets/NEP6/ScryptParameters.cs 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bc36c3...6acea47. Read the comment docs.

igormcoelho added some commits Jun 20, 2019

@igormcoelho

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

@erikzhang I need a small help here... do you know why second test is giving null for ScryptParameters inside NEP6Wallet?
Sorry to bother you, this is a small thing.. but still, strange for a non C# coder.

igormcoelho added some commits Jun 20, 2019

@igormcoelho

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

Nevermind, all tests passed now!! \o/

igormcoelho added some commits Jun 20, 2019

@igormcoelho igormcoelho requested a review from erikzhang Jun 20, 2019

@igormcoelho

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2019

@vncoelho json wallet, fine for you?

@igormcoelho igormcoelho merged commit dfed8ba into neo-project:master Jun 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vncoelho vncoelho deleted the igormcoelho:feat_3x_test_json_nep6wallet branch Jun 21, 2019

KickSeason added a commit to KickSeason/neo that referenced this pull request Jul 9, 2019

Json NEP6Wallet with basic tests (neo-project#847)
* Json NEP6Wallet with basic tests

* Scrypt is null, why

* testing ScryptParameters

* ScryptParameters not null, then null, why

* string is correct, still null

* shouldnt be null

* correctly using out for readonly

* reading from json

* format

* Scrypt to lowercase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.