Script header #903
Script header #903
Conversation
Codecov Report
@@ Coverage Diff @@
## master #903 +/- ##
==========================================
+ Coverage 52.05% 52.17% +0.12%
==========================================
Files 178 179 +1
Lines 12662 12707 +45
==========================================
+ Hits 6591 6630 +39
- Misses 6071 6077 +6
Continue to review full report at Codecov.
|
neo/SmartContract/NefFile.cs
Outdated
| public void Serialize(BinaryWriter writer) | ||
| { | ||
| writer.Write((int)Magic); | ||
| writer.WriteFixedString(Compiler, 32); |
There was a problem hiding this comment.
32 bytes compiler? isn't it much?
There was a problem hiding this comment.
Microsoft Visual Studio 2019
It consumes 28 bytes.
neo/SmartContract/NefFile.cs
Outdated
| /// <summary> | ||
| /// Version | ||
| /// </summary> | ||
| public Version Version { get; set; } |
There was a problem hiding this comment.
Which version is this? Neo (core) version? NeoVM version? Perhaps both?
But since every Neo (core) release carries a specific NeoVM version, it's fine to just use Neo (core) version I guess.
Or is it Compiler + Devpack version? hahaha too many versions... perhaps it's compiler related this, right? It would be good to have some minimal protocol version here, to differentiate between Neo2 and Neo3, and perhaps other affiliated Neo protocols.
There was a problem hiding this comment.
(Mayor, Minor, Build, Version)
Co-Authored-By: Igor Machado Coelho <igor.machado@gmail.com>
Now we don't request these in the deployment. |
|
If we want to accept ONT file format, is easier with an enum |
For ONT, we have |
|
|
|
If is moved to neo-vm we need to remove the hash |
|
i think that we should add the ABI, are you agree @erikzhang? |
I prefer ABI in a separate file. |
|
Here we go! |
* add big and little endian usage * Update endian.md * Update endian.md * Update endian.md * Update endian.md * Update endian.md
* Script header * Script header draft * Clean files * Typo * Rename class and magic header * Clean hash * UT * Erik's suggestions * Change name * Typo * Check magic * 64 to 32 * Nef file only for neo-cli * Real Checksum * Clean * Clean again * Remove code * Update neo/SmartContract/NefFile.cs Co-Authored-By: Igor Machado Coelho <igor.machado@gmail.com> * Enum to const * Remove unnecessary change * Apply Erik's suggestions
Close #889