Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove minner tx hole #934

Merged
merged 3 commits into from
Jul 22, 2019
Merged

Conversation

shargon
Copy link
Member

@shargon shargon commented Jul 18, 2019

No description provided.

@shargon shargon requested a review from erikzhang July 18, 2019 09:10
@codecov-io
Copy link

codecov-io commented Jul 18, 2019

Codecov Report

Merging #934 into master will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #934      +/-   ##
==========================================
- Coverage   45.53%   45.52%   -0.01%     
==========================================
  Files         178      178              
  Lines       12635    12636       +1     
==========================================
  Hits         5753     5753              
- Misses       6882     6883       +1
Impacted Files Coverage Δ
neo/Network/P2P/Payloads/Block.cs 87.65% <66.66%> (-1.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e7bee4...8702117. Read the comment docs.

Copy link
Contributor

@igormcoelho igormcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally having a precise count here. Very good ;)

Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eagle eyes. Good that you remember.

neo/Network/P2P/Payloads/Block.cs Show resolved Hide resolved
@vncoelho vncoelho merged commit 5b321fb into neo-project:master Jul 22, 2019
@erikzhang
Copy link
Member

Noooooooooooo.

It's not for minner tx. It's for ConsensusData.

public ConsensusData ConsensusData;

Please revert it.

shargon added a commit to shargon/neo that referenced this pull request Jul 22, 2019
@shargon
Copy link
Member Author

shargon commented Jul 22, 2019

Reverted!

@erikzhang erikzhang deleted the remove-minner-tx-hole branch July 22, 2019 10:01
erikzhang pushed a commit that referenced this pull request Jul 22, 2019
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
* 新的logo以及样式调整

* Update site.min.js

* update site map
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
Tommo-L pushed a commit to Tommo-L/neo that referenced this pull request Jun 22, 2020
* Remove minner tx hole

* Fix equals
Tommo-L pushed a commit to Tommo-L/neo that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants