Fixes #1372: apoc.load.html ability to read runtime structure of the page #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cture of the page
conker84
requested changes
May 20, 2021
fbiville
reviewed
May 27, 2021
| result -> { | ||
| Map<String, Object> value = (Map<String, Object>) result.get("value"); | ||
| final List<Map<String, Object>> urlTestList = (List<Map<String, Object>>) value.get("urlTest"); | ||
| urlTestList.forEach(tag -> { |
There was a problem hiding this comment.
maybe compare urlTestList to a predefined List<Map<...>>? It may be easier to read than the current switch block
fbiville
approved these changes
Jun 11, 2021
| @@ -233,6 +233,20 @@ public void testQueryWithFailsSilentlyWithListWithExceptionIfIncorrectCharset() | |||
| testIncorrectCharset("CALL apoc.load.html('" + VALID_PATH + "',{a:'a'}, {failSilently: 'WITH_LIST', charset: '" + INVALID_CHARSET + "'})"); | |||
| } | |||
|
|
|||
| @Test(expected = QueryExecutionException.class) | |||
| public void testFailsWithIncorrectBrowser() { | |||
There was a problem hiding this comment.
why not use the ExpectedExceptionJunit 4 Rule? This would make the flow much easier to (write and) read?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1372
LoadHtmlTestParameterized.javaLoadHtmlConfigselenium-dependenciesinextra-dependencieslike MongoDb / Couchbase drivers