Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1873: Add a validation in apoc.custom.* output/input parameters #2046

Merged
merged 11 commits into from Jul 27, 2021
Merged

Fixes #1873: Add a validation in apoc.custom.* output/input parameters #2046

merged 11 commits into from Jul 27, 2021

Conversation

vga91
Copy link
Collaborator

@vga91 vga91 commented Jun 30, 2021 •
edited

Fixes #1873
Fixes #2032

  • Changed logic to retrieve descriptive "Syntax error" instead of previous generic NullPointerException
  • Added check to compare required query parameters and required output columns with the parameters entered by the user
  • Removed signatureParser.getNumberOfSyntaxErrors() (line 49 in Signature.java) and added checkSignatureSyntax to intercept all errors (due to signatureParser.procedure() and signatureParser.function())
  • Fixes small typos in cypher-based-procedures-functions.adoc

@fbiville fbiville self-requested a review July 23, 2021 14:51
@JMHReif JMHReif merged commit eaa24da into neo4j-contrib:4.1 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbiville fbiville fbiville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vga91 @fbiville @JMHReif