Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of deprecated procedure db.constraints #2328

Merged
merged 2 commits into from Nov 17, 2021

Conversation

burqen
Copy link

@burqen burqen commented Nov 12, 2021

No description provided.

Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found two typos I think

assertEquals(1, result.size());
Map<String, Object> firstResult = result.get(0).asMap();
assertEquals("CONSTRAINT ON ( foo:Foo ) ASSERT (foo.foo, foo.bar) IS NODE KEY", firstResult.get("description"));
assertThat( (String) firstResult.get( "createStatement" ) )
.contains( "CREATE CONSTRAINT", "FOR (foo:`Foo`) REQUIRE (foo.`foo`, foo.`bar`) IS UNIQUE" );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.contains( "CREATE CONSTRAINT", "FOR (foo:`Foo`) REQUIRE (foo.`foo`, foo.`bar`) IS UNIQUE" );
.contains( "CREATE CONSTRAINT", "FOR (foo:`Foo`) REQUIRE (foo.`foo`, foo.`bar`) IS NODE KEY" );

assertEquals(1, result.size());
Map<String, Object> firstResult = result.get(0).asMap();
assertEquals("CONSTRAINT ON ( foo:Foo ) ASSERT (foo.baa, foo.baz) IS NODE KEY", firstResult.get("description"));
assertThat( (String) firstResult.get( "description" ) )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assertThat( (String) firstResult.get( "description" ) )
assertThat( (String) firstResult.get( "createStatement" ) )

@burqen
Copy link
Author

burqen commented Nov 16, 2021

@Lojjs Good catches! Thank you 🙏

Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now as far as I can judge without a build

@Lojjs Lojjs merged commit 29372fb into neo4j-contrib:dev Nov 17, 2021
@burqen burqen deleted the 5.0-ap-show-constraints branch November 17, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants