Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1132: add ability to all export procedures to compress their data #2482

Merged
merged 2 commits into from Mar 16, 2022

Conversation

vga91
Copy link
Collaborator

@vga91 vga91 commented Jan 26, 2022

Fixes #1132

  • Added the config compression to compress file, even in a stream way.
  • Changed, in ExportCypher.java and in drain() method, thclass types from String to Object, in order to support compressed byte[].
  • Added ExportConfig (which extend CompressionConfig) where needed.
  • Changed StreamConnection.toCountingInputStream() method to support the compressed import/export roundrip (previously it was not possible to import files from url in an compressed way, but only binary file)
  • For the above reason, changed the default compression type from GZIP to NONE into CsvLoaderConfig.java, otherwise by default every import from fileUrl would have required a GZIP file. For this reason, changed ImportCSVTest.ignoreFieldTypeWithBothBinaryAndFileUrl()

@vga91 vga91 force-pushed the issue_1132 branch 3 times, most recently from 9039a5f to 7f39056 Compare February 3, 2022 17:00
@JMHReif JMHReif merged commit eadbbf9 into neo4j-contrib:4.2 Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants