Fixes #2402: See if we can make the aStar algorithm support spatial points #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort spatial points
Lojjs
added
4.4
core-functionality
Lojjs
reviewed
Apr 19, 2022
| @Context | ||
| public GraphDatabaseService db; | ||
|
|
||
| @Context | ||
| public Transaction tx; | ||
|
|
||
| @Procedure | ||
| @Description("apoc.algo.aStarWithPoint(startNode, endNode, 'relTypesAndDirs', 'distance','pointProp') - " + |
There was a problem hiding this comment.
We have started to be stricter about what will be added into APOC core. Would it be possible to add this into APOC full instead?
There was a problem hiding this comment.
Yes sure, I just moved it in full
Lojjs
reviewed
Apr 21, 2022
| @@ -45,8 +94,8 @@ public Stream<WeightedPathResult> aStar( | |||
| } | |||
|
|
|||
| @Procedure | |||
| @Description("apoc.algo.aStar(startNode, endNode, 'KNOWS|<WORKS_WITH|IS_MANAGER_OF>', {weight:'dist',default:10," + | |||
| "x:'lon',y:'lat'}) YIELD path, weight - run A* with relationship property name as cost function") | |||
| @Description("apoc.algo.aStarConfig(startNode, endNode, 'KNOWS|<WORKS_WITH|IS_MANAGER_OF>', {weight:'dist',default:10," + | |||
There was a problem hiding this comment.
Nice catch that this description was wrong 👍
Lojjs
approved these changes
Apr 21, 2022
neo4j-oss-build
pushed a commit
that referenced
this pull request
Apr 21, 2022
neo4j-oss-build
pushed a commit
that referenced
this pull request
Apr 21, 2022
Lojjs
pushed a commit
that referenced
this pull request
Apr 21, 2022
Lojjs
pushed a commit
that referenced
this pull request
Apr 21, 2022
Lojjs
pushed a commit
that referenced
this pull request
Apr 25, 2022
Lojjs
added a commit
that referenced
this pull request
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2402
Added config 'pointPropName' in
apoc.algo.aStarConfigprocedure.Extracted code from org.neo4j.graphalgo.impl.util.GeoEstimateEvaluator