Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated query and transaction management procedures and replace with SHOW/TERMINATE TRANSACTION #2622

Merged
merged 4 commits into from Mar 16, 2022
Merged

Remove deprecated query and transaction management procedures and replace with SHOW/TERMINATE TRANSACTION #2622

merged 4 commits into from Mar 16, 2022

Conversation

phil198
Copy link

@phil198 phil198 commented Mar 9, 2022

Replace mentions and usages of the following deprecated procedures:

  • dbms.listTransactions()
  • dbms.killTransaction()
  • dbms.killTransactions()
  • dbms.listQueries()
  • dbms.killQuery()
  • dbms.killQueries()

With SHOW TRANSACTIONS and TERMINATE TRANSACTION

HannesSandberg
HannesSandberg approved these changes Mar 10, 2022
View reviewed changes
Copy link

@HannesSandberg HannesSandberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good to me 👍

@ncordon ncordon self-requested a review March 10, 2022 09:31
@ncordon ncordon added the team-cypher-surface Cypher Surface team should review the PR label Mar 10, 2022
@phil198
Copy link
Author

phil198 commented Mar 10, 2022

Remove deprecated procedures for listing and terminating transactions and queries

@phil198 phil198 force-pushed the dev-remove-deprecated-transaction-procedures branch from 5f5b3b8 to 73130bf Compare March 15, 2022 11:02
@phil198 phil198 force-pushed the dev-remove-deprecated-transaction-procedures branch from 73130bf to e2fd42a Compare March 16, 2022 10:36
@phil198 phil198 merged commit 8ae11b7 into dev Mar 16, 2022
@phil198 phil198 deleted the dev-remove-deprecated-transaction-procedures branch March 16, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncordon ncordon ncordon approved these changes

@HannesSandberg HannesSandberg HannesSandberg approved these changes

Assignees

@HannesSandberg HannesSandberg

Labels
team-cypher-surface Cypher Surface team should review the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phil198 @ncordon @HannesSandberg