Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses service account token when cherry-picking #2752

Merged
merged 2 commits into from Apr 14, 2022

Conversation

ncordon
Copy link
Contributor

@ncordon ncordon commented Apr 14, 2022

This was approved in #2741 but it had to be reverted due to an external problem with the actions and a new version of git. This should have been solved by #2751 (see that PR for more context).

What

Uses a personal access token for the service account https://github.com/neo4j-oss-build when cherry picking.

Why

That should trigger the CI for us automatically when creating the automatic cherry-picks PR, according to the solutions proposed in peter-evans/create-pull-request#48, contrary to what's happening at the moment.

@ncordon ncordon added bug to-cherry-pick issues related to commits to cherry-pick team-cypher-surface Cypher Surface team should review the PR 5.0 labels Apr 14, 2022
@ncordon ncordon self-assigned this Apr 14, 2022
@ncordon ncordon merged commit d021726 into dev Apr 14, 2022
@ncordon ncordon deleted the dev-use-service-account-token branch April 14, 2022 15:19
ncordon added a commit that referenced this pull request Apr 14, 2022
Co-authored-by: Nacho Cordón <ncordon@users.noreply.github.com>
neo4j-oss-build added a commit that referenced this pull request Apr 14, 2022
Co-authored-by: Nacho Cordón <ncordon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 bug team-cypher-surface Cypher Surface team should review the PR to-cherry-pick issues related to commits to cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant