-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2723: apoc.load.xml on large file generates OoM Errors #2841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some of queries in the documentation need to be updated. Otherwise it looks good to me 👍
[options="header"] | ||
|=== | ||
| value | ||
| {"_children":[{"_type":"data","_text":":Movie","key":"labels"},{"_type":"data","_text":"The Matrix","key":"title"},{"_type":"data","_text":"Welcome to the Real World","key":"tagline"},{"_type":"data","_text":"1999","key":"released"}],"_type":"node","id":"n0","labels":":Movie"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be '/graphml/graph/*', shouldn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I get slightly different results for my (outdated) 4.3 apoc version. I wonder if we might need different documentation there? 💭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, some copy-paste error. Updated it.
Now i added a YIELD value RETURN value ORDER BY value.id
just to make sure the result is consistent for each neo4j version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So for clarification, the result I get from my 4.3.2 neo4j version for the first statement is:
{"_type":"node","_children":[{"_type":"data","_text":":Movie","key":"l│ │abels"},{"_type":"data","_text":"The Matrix","key":"title"},{"_type":"│ │data","_text":"Welcome to the Real World","key":"tagline"},{"_type":"d│ │ata","_text":"1999","key":"released"}],"id":"n0","labels":":Movie"}
So, I think the structure is inherently different. I haven't updated the apoc version installed some time ago, so it might be because of that. But it's definitely interesting 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, yes it should depend on the version, thanks for the clarification
[options="header"] | ||
|=== | ||
| value | ||
| {"_children":[{"_type":"data","_text":":Movie","key":"labels"},{"_type":"data","_text":"The Matrix","key":"title"},{"_type":"data","_text":"Welcome to the Real World","key":"tagline"},{"_type":"data","_text":"1999","key":"released"}],"_type":"node","id":"n0","labels":":Movie"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So for clarification, the result I get from my 4.3.2 neo4j version for the first statement is:
{"_type":"node","_children":[{"_type":"data","_text":":Movie","key":"l│ │abels"},{"_type":"data","_text":"The Matrix","key":"title"},{"_type":"│ │data","_text":"Welcome to the Real World","key":"tagline"},{"_type":"d│ │ata","_text":"1999","key":"released"}],"id":"n0","labels":":Movie"}
So, I think the structure is inherently different. I haven't updated the apoc version installed some time ago, so it might be because of that. But it's definitely interesting 😄
Fixes #2723
Added more doc and tests about xpath, in order to use streaming