Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #2909. #2996

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Fix for #2909. #2996

merged 1 commit into from
Jun 27, 2022

Conversation

tomocesnik
Copy link
Contributor

Fixes #2909

Instead of passing the actual size of the map (which could be 0) to the constructor for MapValueBuilder, the constructor is called without parameters. This functionality is provided by Neo4j and for some reason the constructor with the parameter throws an exception for value 0.

@Lojjs Lojjs self-assigned this Jun 20, 2022
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @tomocesnik, this makes sense to me. I will take care of merging and porting it to the other versions.

@Lojjs Lojjs merged commit 2dd91c8 into neo4j-contrib:4.4 Jun 27, 2022
neo4j-oss-build pushed a commit that referenced this pull request Jun 27, 2022
Co-authored-by: Tomo Česnik <tomo.cesnik@tus.si>
neo4j-oss-build pushed a commit that referenced this pull request Jun 27, 2022
Co-authored-by: Tomo Česnik <tomo.cesnik@tus.si>
Lojjs pushed a commit that referenced this pull request Jun 27, 2022
Co-authored-by: Tomo Česnik <tomo.cesnik@tus.si>
Lojjs pushed a commit that referenced this pull request Jun 27, 2022
Co-authored-by: Tomo Česnik <tomo.cesnik@tus.si>
vga91 pushed a commit to vga91/neo4j-apoc-procedures that referenced this pull request Jun 29, 2022
Co-authored-by: Tomo Česnik <tomo.cesnik@tus.si>
gem-neo4j pushed a commit to gem-neo4j/neo4j-apoc-procedures that referenced this pull request Jul 12, 2022
… NO AUTO

Co-authored-by: Tomo Česnik <tomo.cesnik@tus.si>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apoc Procedures can't return empty map
2 participants