Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO AUTO Adds missing WAIT in CREATE DATABASE #3047

Merged
merged 1 commit into from Jul 15, 2022
Merged

NO AUTO Adds missing WAIT in CREATE DATABASE #3047

merged 1 commit into from Jul 15, 2022

Conversation

ncordon
Copy link
Contributor

@ncordon ncordon commented Jul 12, 2022

CREATE DATABASE is not synchronous by default anymore in a single instance, so we need to add WAIT

@ncordon ncordon added 5.0 team-cypher-surface Cypher Surface team should review the PR labels Jul 12, 2022
gem-neo4j
gem-neo4j approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@gem-neo4j gem-neo4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ncordon ncordon changed the title Adds missing WAIT in CREATE DATABASE NO AUTO Adds missing WAIT in CREATE DATABASE Jul 15, 2022
@ncordon ncordon merged commit 9004203 into dev Jul 15, 2022
@ncordon ncordon deleted the await-create-database branch July 15, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gem-neo4j gem-neo4j gem-neo4j approved these changes

Assignees

@gem-neo4j gem-neo4j

Labels
5.0 team-cypher-surface Cypher Surface team should review the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ncordon @gem-neo4j