NO AUTO Makes container wait for neo4j database ready #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncordon
added
bug
5.0
team-cypher-surface
gfx54b
approved these changes
Jul 19, 2022
ncordon
changed the title
nadja-muller
approved these changes
Jul 20, 2022
gem-neo4j
pushed a commit
that referenced
this pull request
Jul 21, 2022
AzuObs
pushed a commit
that referenced
this pull request
Jul 28, 2022
* Remove deprecated procedures * Remove references of deprecated procedures from all documentation * Add documentation about deprecation removals * Bring back apoc.warmup.run (deprecated 5.0 only) * Add deprecation documentation around the removed APOC config setting * Convert old tests of deprecated functions into ones of their replacements * NO AUTO Makes container wait for neo4j database ready (#3065) * Fix failing test (looking for now removed procedure) * Add updated mongodb back into navigation Co-authored-by: Nacho Cordón <ncordon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neo4j 5.x reconciler is eventually consistent now, which means on startup we cannot assume neo4j will be ready and we have to wait for it to be.
The inspiration for this came from the official neo4j-docker test utils. Thanks @gfx54b for the help.