Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO AUTO Moves export procedures to core only #3086

Merged
merged 3 commits into from Aug 3, 2022
Merged

NO AUTO Moves export procedures to core only #3086

merged 3 commits into from Aug 3, 2022

Conversation

ncordon
Copy link
Contributor

@ncordon ncordon commented Aug 2, 2022 •
edited

Strips core export procedures and functions from full package.

To be merged after #3085.

@ncordon ncordon added 5.0 team-cypher-surface Cypher Surface team should review the PR labels Aug 2, 2022
@ncordon ncordon changed the base branch from dev to dev-strip-coll-procs August 2, 2022 09:24
ncordon
ncordon commented Aug 2, 2022
View reviewed changes
full/build.gradle
testImplementation project(':test-utils')
testImplementation project(":core")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately we need to add this for the moment: full->test depending on core. I don't know whether we are going to be able to take out this dependency easily.

@ncordon ncordon changed the base branch from dev-strip-coll-procs to dev August 2, 2022 10:30
@ncordon ncordon mentioned this pull request Aug 2, 2022
Merged
@ncordon ncordon added the split Work related to splitting apoc core and full label Aug 2, 2022
@ncordon ncordon mentioned this pull request Aug 3, 2022
Merged
AzuObs
AzuObs approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@AzuObs AzuObs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looks like I also reviewed this in the bigger PR (this had a few slight difference but still good to go)

@ncordon ncordon merged commit d160c66 into dev Aug 3, 2022
@ncordon ncordon deleted the dev-strip-export-procs branch August 3, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzuObs AzuObs AzuObs approved these changes

Assignees

@AzuObs AzuObs

Labels
5.0 split Work related to splitting apoc core and full team-cypher-surface Cypher Surface team should review the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ncordon @AzuObs