NO AUTO Adds blocklist for load methods #3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncordon
added
cherry-picked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks #2467
What
Uses Neo4j internal option
unsupported.dbms.cypher_ip_blocklist, which consists on a list of ip addresses in CDIR notation, i.e. ip + mask for subnets, e.g.192.167.2.3/8, 192.234.3.123/16. When using theapoc.load.json(url)command, the url will be looked up in a DNS resolver and we will fail if it is on the list of blocked ip addresses.Why
To prevent users trying to load data from any url. To completely block all ipv4 and ipv6 addresses one should use: