NO AUTO Does a tidy-up and clean-up after splitting most of the code #3123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ncordon
commented
Aug 9, 2022
ncordon
commented
- Moves more files to full (the ones that are only needed there and not in core)
- Tidy ups dependencies: there were lots of unused things.
- Removes sonarqube plugin. I don't think this was used anymore, this is from the old days when the code was published to Sonar rather than Maven.
ncordon
force-pushed
the
dev-split-cleanup
branch
2 times, most recently
from
1591d60
to
5b9fc3e
Compare
ncordon
force-pushed
the
dev-split-cleanup
branch
from
5b9fc3e
to
deceb77
Compare
AzuObs
reviewed
Aug 10, 2022
| testImplementation group: 'org.eclipse.jetty', name: 'jetty-server', version: '9.2.22.v20170606' | ||
| testImplementation group: 'org.apache.derby', name: 'derby', version: '10.12.1.1' | ||
|
|
||
| testImplementation group: 'org.postgresql', name: 'postgresql', version: '42.1.4' |
There was a problem hiding this comment.
It looks like a test for the Postgres driver is failing for a genuine reason. Could be that this Postgres dependency is needed?
You may wish to run the tests locally if you haven't already, since many of these types of tests are probably disabled in the CI.
There was a problem hiding this comment.
Yep good catch, I've brought back this, but I don't understand how the code compiles if we need it in runtime
AzuObs
reviewed
Aug 10, 2022
| }); | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
I think you may have wanted to delete the src/test/Examples.java instead of the src/test/ExamplesTest.java?
ncordon
force-pushed
the
dev-split-cleanup
branch
from
37be438
to
167a884
Compare
ncordon
force-pushed
the
dev-split-cleanup
branch
from
167a884
to
af2bca2
Compare
ncordon
commented
Aug 10, 2022
| @@ -71,7 +70,7 @@ subprojects { | |||
|
|
|||
| // neo4jDockerImage system property is used in TestContainerUtil | |||
| systemProperties 'user.language' : 'en' , | |||
| 'user.country ' : 'US', | |||
| 'user.country' : 'US', | |||
There was a problem hiding this comment.
This was spotted by @AzuObs, not me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.