Extended changes after fix core ignored s3 tests #3295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vga91
force-pushed
the
ext_changes_after_fix_core_ignored_s3_test
branch
from
9f9340a
to
4cdc923
Compare
vga91
force-pushed
the
ext_changes_after_fix_core_ignored_s3_test
branch
from
4cdc923
to
78db2d8
Compare
vga91
force-pushed
the
ext_changes_after_fix_core_ignored_s3_test
branch
from
78db2d8
to
2cef343
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
S3BaseTestinstead of currentminio = new S3Container();, in@Before,because the latter is flaky, as well as heavier.
The
new S3Container()placed in@BeforeClassseems to be stable.Waiting for neo4j/apoc#241Waiting for S3 flaky tests resolutions: e.g. trello id[0eSjZq6Q]add putFile(..) in core: neo4j/apoc@9b8e78a#diff-22ce2fb661ac3313a1c6cd885bb792112918c96d48975ad9ef1afff7cdd38c8aL60