[aNcPaEFK] Fix LoadLdapTest.testLoadLDAP #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
vga91
force-pushed
the
fix-testLoadLDAP
branch
from
5839d28
to
e65c2dc
Compare
vga91
added a commit
that referenced
this pull request
Feb 21, 2023
vga91
added a commit
that referenced
this pull request
Feb 21, 2023
vga91
added a commit
that referenced
this pull request
Feb 27, 2023
vga91
added a commit
that referenced
this pull request
Feb 27, 2023
vga91
added a commit
that referenced
this pull request
Feb 27, 2023
vga91
added a commit
that referenced
this pull request
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new extended PRs fail both on 4.x and 5.x,
it seems for the same reason as this other pr: #3022.
To avoid other problems in the future,
I created an embedded mock server instead of using remote url.
Also I noticed that the actual procedure (ie
call apoc.load.ldap($conn, $search)) is not tested,but just the internal method calling the config is checked,
so I added a test that does the procedure query, to verify that it really works.