[V8keNXu0] error details while using apoc.cypher.run* procedures #3668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conker84
requested changes
Jul 24, 2023
| } | ||
| }); | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private Object getError(BlockingQueue<RowResult> queue, boolean reportError, Exception e, String fileName) { |
There was a problem hiding this comment.
Suggested change
| private Object getError(BlockingQueue<RowResult> queue, boolean reportError, Exception e, String fileName) { | |
| private void getError(BlockingQueue<RowResult> queue, boolean reportError, Exception e, String fileName) { |
| } | ||
| }); | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private Object getError(BlockingQueue<RowResult> queue, boolean reportError, Exception e, String fileName) { | ||
| if (reportError) { |
There was a problem hiding this comment.
I would reverse the condition check:
Suggested change
| if (reportError) { | |
| if (!reportError) { |
|
|
||
| RowResult result = new RowResult(-1, Map.of("error", error)); | ||
| QueueUtil.put(queue, result, 10); | ||
| return null; |
There was a problem hiding this comment.
if you reverse the condition you can get rid of this
conker84
approved these changes
Jul 25, 2023
vga91
added a commit
that referenced
this pull request
Jul 25, 2023
* [V8keNXu0] error details while using apoc.cypher.run* procedures * Added long-running query (~1min) * Small changes review * Changed method name
vga91
added a commit
that referenced
this pull request
Dec 22, 2023
* [V8keNXu0] error details while using apoc.cypher.run* procedures * Added long-running query (~1min) * Small changes review * Changed method name
vga91
added a commit
that referenced
this pull request
Dec 22, 2023
* [V8keNXu0] error details while using apoc.cypher.run* procedures * Added long-running query (~1min) * Small changes review * Changed method name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reportErrorconfig to retrieve aMap.of("error", "<ERROR_OBTAINED>"), if any