Fixes #3775: apoc.load.ldap doesn't work with SSL #4010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vga91
added a commit
that referenced
this pull request
Apr 2, 2024
vga91
added a commit
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3775
With the current library, it fails to use SSL, as it gives the same error reported on the issue, either using SSLUtil as currently done, or using a method similar to this, which I tried to use here: vga91@5585b91.
So I think the ideal solution is to change the library with the one already included in the
LoadLdapTest.javaand it works similarly to the current library.The two libraries should report compatible results, since the
setMaxResults(0)given in the old library is not necessary since with the new library the sizeLimit is 0. As well astypeOnly.Removed
ldapVersion = = LDAPConnection.LDAP_V3since the library is already set in LdapV3.For testing, I used a test container with openldap that already has TLS enabled.