Solve 5.21 compile errors #4126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vga91
added
to-cherry-pick
* Added CypherScope.CYPHER_5 * Fix compile 5.21 errors after restore submodule * solve error: cannot find symbol, due to org.neo4j.kernel.api.procedure.ProcedureView 5.21 changes * fix ParquetTest.testStreamRoundtripParquetAllWithImportExportConfsDisabled * fix LoadCsvTest.testWithSpacesInFileName
vga91
force-pushed
the
solve-5.21-compile-errors
branch
from
03c0b73
to
1cbda79
Compare
vga91
added a commit
that referenced
this pull request
Jul 10, 2024
* Solve 5.21 compile errors * Added CypherScope.CYPHER_5 * Fix compile 5.21 errors after restore submodule * solve error: cannot find symbol, due to org.neo4j.kernel.api.procedure.ProcedureView 5.21 changes * fix ParquetTest.testStreamRoundtripParquetAllWithImportExportConfsDisabled * fix LoadCsvTest.testWithSpacesInFileName * fix SystemDbTest.testGetGraph
vga91
added a commit
that referenced
this pull request
Jul 11, 2024
* Try to solve 5.21 TC errors (#4137) * Try to solve 5.21 TC errors * de-ignored gradle.properties to be consistent with Core one * Solve 5.21 compile errors (#4126) * Solve 5.21 compile errors * Added CypherScope.CYPHER_5 * Fix compile 5.21 errors after restore submodule * solve error: cannot find symbol, due to org.neo4j.kernel.api.procedure.ProcedureView 5.21 changes * fix ParquetTest.testStreamRoundtripParquetAllWithImportExportConfsDisabled * fix LoadCsvTest.testWithSpacesInFileName * fix SystemDbTest.testGetGraph * Update .gitmodules to 5.21
gmarcostam
pushed a commit
to gmarcostam/neo4j-apoc-procedures
that referenced
this pull request
Jul 11, 2024
* Solve 5.21 compile errors * Added CypherScope.CYPHER_5 * Fix compile 5.21 errors after restore submodule * solve error: cannot find symbol, due to org.neo4j.kernel.api.procedure.ProcedureView 5.21 changes * fix ParquetTest.testStreamRoundtripParquetAllWithImportExportConfsDisabled * fix LoadCsvTest.testWithSpacesInFileName * fix SystemDbTest.testGetGraph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve 5.21 compile errors
Added CypherScope.CYPHER_5, added here, which annotates procedures usable in Cypher 5.x
Changed namespace from List to String[], as in neo4j 5.21 the QualifiedName no longer accept List
Fixed various 5.21 compile errors due to APOC Core changes,
See here
Changed ParquetTest.testStreamRoundtripParquetAllWithImportExportConfsDisabled,
since FileUtils now has a method apocConfig().checkReadAllowed(url, urlAccessChecker);
Changed
LoadCsvTest.testWithSpacesInFileName,since FileUtils.changeFileUrlIfImportDirectoryConstrained now has a method getLoadFileUrl(...),
which makes the procedure fail if we have a file name like
name with spacesinstead offile:///name%20with%20spaces,and on which we cannot change the code, as it's in Core
Changed
SystemDbTestdue to new System Label "Auth" and Rel-type "HAS_AUTH", see here