Issue #542: Add a strategy to merge edge nodes properties when creating relationships using Relationship pattern strategy #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroiter-larus
force-pushed
the
issue_542
branch
from
6d345ed
to
3de0487
Compare
conker84
reviewed
Nov 18, 2022
| @@ -31,4 +31,3 @@ Thumbs.db | |||
| bin | |||
| doc/node | |||
| doc/node_modules | |||
|
|
|||
There was a problem hiding this comment.
can you please restore it?
conker84
suggested changes
Nov 18, 2022
| @@ -71,6 +74,8 @@ class Neo4jSinkConnectorConfig(originals: Map<*, *>): Neo4jConnectorConfig(confi | |||
| const val TOPIC_CDC_SCHEMA = "neo4j.topic.cdc.schema" | |||
| const val TOPIC_CUD = "neo4j.topic.cud" | |||
|
|
|||
| const val MERGE_PROPERTIES_ENABLED = "neo4j.merge.properties.enabled" | |||
There was a problem hiding this comment.
Suggested change
| const val MERGE_PROPERTIES_ENABLED = "neo4j.merge.properties.enabled" | |
| const val TOPIC_PATTERN_MERGE_NODE_PROPERTIES_ENABLED = "neo4j.topic.pattern.merge.node.properties.enabled" | |
| const val TOPIC_PATTERN_MERGE_RELATIONSHIP_PROPERTIES_ENABLED = "neo4j.topic.pattern.merge.relationship.properties.enabled" |
And please adapt all accordingly.
mroiter-larus
force-pushed
the
issue_542
branch
from
3de0487
to
03fffe8
Compare
…s when creating relationships using Relationship pattern strategy
mroiter-larus
force-pushed
the
issue_542
branch
from
03fffe8
to
fb4dfd5
Compare
conker84
force-pushed
the
issue_542
branch
2 times, most recently
from
0e9bf7c
to
f02042b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #542
Proposed Changes (Mandatory)
neo4j.merge.properties.enabled: If enabled edge nodes properties will be merged when creating relationships using sinkRelationship pattern strategy(default false: edge node properties will be overwritten).