dbmss info subscription #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nglgzz
reviewed
Oct 4, 2021
| @Context('environment') environment: Environment, | ||
| ): Promise<AsyncIterator<unknown, any, undefined>> { | ||
| // @todo: this isn't fleshed out yet and is simplistic | ||
| // @todo: how to detect or handle unsubsribe? how to handle multiple watchers for an env? |
There was a problem hiding this comment.
Might be worth looking into this: nestjs/graphql#186 (comment)
There was a problem hiding this comment.
Yeah I looked into this. I couldn't get it to work yet but can take another look.
There was a problem hiding this comment.
Left a note in the PR description. Just wondering if I should look into this and get it working now? Or save for next phase?
| }); | ||
|
|
||
| const eventHandler = (e: string) => { | ||
| const dbmsIdCheck = e.match(/dbms-([^/]*)/); |
There was a problem hiding this comment.
Suggested change
| const dbmsIdCheck = e.match(/dbms-([^/]*)/); | |
| const dbmsIdCheck = e.match(/dbms-([^/]+)/); |
| // @todo: how to detect or handle unsubsribe? how to handle multiple watchers for an env? | ||
| if (!environmentWatchers.get(environment.id)) { | ||
| // set watcher for environment | ||
| const setWatcher = (watchPath: string) => { |
There was a problem hiding this comment.
Could be worth extracting this into a util
There was a problem hiding this comment.
Ill see. It might become more obvious when we add another subscription later. Ill look into it.
jk05
force-pushed
the
dbmss-info-subscription
branch
from
7d6ca73
to
36ed76f
Compare
jk05
commented
Oct 4, 2021
| @Context('environment') environment: Environment, | ||
| ): Promise<AsyncIterator<unknown, any, undefined>> { | ||
| if (!environmentWatchers.get(environment.id)) { | ||
| const watcher = setWatcher(path.join(environment.dirPaths.dbmssData, '**', 'run', '*.pid')); |
There was a problem hiding this comment.
will assign this path to a variable somewhere better at the end.
jk05
force-pushed
the
dbmss-info-subscription
branch
4 times, most recently
from
cdfd177
to
7ae5d4b
Compare
jk05
force-pushed
the
dbmss-info-subscription
branch
2 times, most recently
from
d49b8ef
to
76efa2e
Compare
jk05
force-pushed
the
dbmss-info-subscription
branch
from
76efa2e
to
50b75e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
graphql-subscriptionsandchokidarin order to set up a watcher looking forneo4j.pidfiles being created / unlinked to establish dbms start / stop and publish an eventWhat is the current behavior?
What is the new behavior?
watchInfoDbmssto getDbmsInfofor a relevant DBMS started / stoppedDoes this PR introduce a breaking change?
No
Other information: