Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Images to CDN #54

Closed
wants to merge 7 commits into from
Closed

Move Images to CDN #54

wants to merge 7 commits into from

Conversation

jexp
Copy link
Contributor

@jexp jexp commented Oct 16, 2020

No description provided.

@jexp jexp requested a review from ggrossetie October 16, 2020 13:07
Copy link
Contributor

@ggrossetie ggrossetie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

And the mixed content issue is fixed on Netlify 🎉

@jexp
Copy link
Contributor Author

jexp commented Oct 22, 2020

@ggrossetie
Copy link
Contributor

for KB shouldn't these be handled by a default image prefix?image:https://s3.amazonaws.com/dev.assets.neo4j.com/kb-content/a-lightweight-approach-to-testing-the-neo4j-rest-api-with-authentication-qq4KTt1.png[image]

That's a good point!
Now that all images are stored in the same place, we can define :imagesdir: https://s3.amazonaws.com/dev.assets.neo4j.com/kb-content in the build.gradle and remove the suffix in all the articles, for instance: image:a-lightweight-approach-to-testing-the-neo4j-rest-api-with-authentication-qq4KTt1.png[].

But I would rather do that in another pull request.
Once this is done, we should document this change in the README.adoc, add an example in the template.adoc and @viveksaran71 should probably add a note in the authoring documentation.

@jexp
Copy link
Contributor Author

jexp commented Oct 23, 2020

Yes to all. If possible I’d do it all in one go.

@ggrossetie
Copy link
Contributor

@jexp I've updated #55
Antora does not allow to override the value of the built-in imagesdir attribute so I'm using :assets-cdn: https://s3.amazonaws.com/dev.assets.neo4j.com/kb-content and images should be declared as:

image::{assets-cdn}/shared-lock.png[Shared Lock]

@jexp jexp closed this Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants