Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GGP-460: testing with @neo4j-labs/temp-dbs #148

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nossila
Copy link

@nossila nossila commented Jun 30, 2021

Proof of concept of using @neo4j-labs/temp-dbs for creating disposable databases for testing.

How to test:

  1. Make sure you have a Neo4j database running locally, you can use Neo4j Desktop for this. Make sure to select at least version 4
  2. Export the right credentials to your environment like:
export NEO4J_URI="bolt://localhost:7687"
export NEO4J_USER="neo4j"
export NEO4J_PASSWORD="123456"
export NEO4J_VERSION="4.2.1"
  1. Install nodejs dependencies npm install
  2. Run tests npm run test

@nossila nossila force-pushed the test-with-temp-db branch 2 times, most recently from c77b0d8 to 2c6a786 Compare June 30, 2021 22:43
Copy link
Contributor

@fbiville fbiville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there more context I can read about this proposed change?

I personally would prefer to stick to a single way of running acceptance tests for all the movies repositories here.
This is currently embodied by https://github.com/neo4j-examples/movies-harness/.

@@ -0,0 +1,25 @@
version: 2.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be preferable to stick to GitHub Actions since it's already in place.

@whatSocks
Copy link
Collaborator

@fbiville the goal is to have an example of using tests using the semi-experimental https://github.com/neo4j-contrib/neo4j-temp-db - we can keep the "real" tests but have the other as an example for third parties to consider for their projects.

temp-db only works with neo4j > 4.0 and
can only create databased on enterprise version
package.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants