updated logic for endNodePattern to include label information in the variable name

[ghost]

updated logic for endNodePattern to include label information in the variable name.

It fixes #295

[Andy2003]

Can you add a test that coveres the bug (with the wrong where-parameters)

[ghost]

Added a test case to validate variable name in where condition.

[ghost]

Hi @Andy2003
I have added a test case to validate variable name in where condition.
Can you please review it?
Thanks

[Andy2003]

why adding test data, if you don't use it in the tests?

[ghost]

In below tests, there are graphql queries which are filtering on node properties. So this "props" is required here.

But in my test case for "wrong variable name in where condition", props is not required. I will remove it from there.

[ghost]

Removed unwanted data from my test case

[Andy2003]

What I meant is that if you add test data, which is perfectly OK, then the test should also check if a particular query returns that data. This is tested using the following block:

.GraphQL-Response
[source,json,response=true,ignore-order]
----
{
 "expected": "graphql response"
}
----

[ghost]

Added Graphql Response

[Andy2003]

Do you want to add integration test assertions?

[ghost]

Hi.
I will add it today. I got held up with some other work.

[ghost]

Do you want to add integration test assertions?

You are talking about adding this response in my test, right?

.GraphQL-Response
[source,json,response=true,ignore-order]
----
{
 "expected": "graphql response"
}
----

[Andy2003]

Please fix the tests!

[ghost]

Please fix the tests!

In my local, all the CypherTests are running fine.

After running mvn clean install, I don't see any test failure in Neo4j GraphQL Java 1.7.1-SNAPSHOT

[Andy2003]

Why did you close this PR? The reason the test ware failing here is, that the integration are also ran. These tests are disabled by default, so your mvn clean install does not run these tests.

[Andy2003]

I will take a look at this