Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6zK6lL5F] Update to use new descriptions for new Cypher Types #496

Merged
merged 2 commits into from
Sep 29, 2023
Merged

[6zK6lL5F] Update to use new descriptions for new Cypher Types #496

merged 2 commits into from
Sep 29, 2023

Conversation

gem-neo4j
Copy link
Contributor

Updates the description to use the new descriptions merged into docs here

@gem-neo4j gem-neo4j force-pushed the dev_update_procedure_function_desc branch from 2773ffe to df0fcda Compare September 20, 2023 11:44
@Lojjs Lojjs self-assigned this Sep 21, 2023
Lojjs
Lojjs requested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there 😅 I compared with what you have done on the docs side, so some of my comments are for the main repo, some for docs and some needs to be updated for both.

core/src/main/java/apoc/agg/MaxAndMinItems.java Show resolved Hide resolved
core/src/main/java/apoc/coll/Coll.java Outdated Show resolved Hide resolved
core/src/main/java/apoc/coll/Coll.java Outdated Show resolved Hide resolved
core/src/main/java/apoc/convert/Json.java Outdated Show resolved Hide resolved
core/src/main/java/apoc/neighbors/Neighbors.java Outdated Show resolved Hide resolved
core/src/main/java/apoc/create/Create.java Show resolved Hide resolved
core/src/main/java/apoc/date/Date.java Show resolved Hide resolved
core/src/main/java/apoc/text/Strings.java Show resolved Hide resolved
core/src/main/java/apoc/refactor/GraphRefactoring.java Show resolved Hide resolved
core/src/main/java/apoc/map/Maps.java Outdated Show resolved Hide resolved
@gem-neo4j gem-neo4j force-pushed the dev_update_procedure_function_desc branch from df0fcda to 09dc023 Compare September 27, 2023 09:00
@gem-neo4j
Copy link
Contributor Author

Thanks for the review! Here is the docs updates: https://github.com/neo4j/docs-apoc/pull/197

@gem-neo4j gem-neo4j merged commit be11e34 into dev Sep 29, 2023
14 checks passed
@gem-neo4j gem-neo4j deleted the dev_update_procedure_function_desc branch September 29, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lojjs Lojjs Lojjs approved these changes

Assignees

@Lojjs Lojjs

Labels
dev team-cypher-surface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gem-neo4j @Lojjs