Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pLz5YbCW] add checks for node labels and relationship types for apoc.merge procedures #503

Merged
merged 8 commits into from
Oct 12, 2023
Merged

[pLz5YbCW] add checks for node labels and relationship types for apoc.merge procedures #503

merged 8 commits into from
Oct 12, 2023

Conversation

nadja-muller
Copy link
Contributor

@nadja-muller nadja-muller commented Oct 3, 2023 •
edited
Loading

apoc.merge.node:

  • if labelNames null is newly considered as an empty label
  • if labelNames contains null values, it is considered as incorrect input
  • if labelNames contains among others an empty string, it is considered as incorrect input

apoc.merge.relationship:

  • if relationship type is null, it is considered as incorrect input
  • if relationship type is empty, it is considered as incorrect input

@Lojjs Lojjs self-assigned this Oct 4, 2023
Lojjs
Lojjs requested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check looks good but I have some comments on the tests and messages.

core/src/test/java/apoc/merge/MergeTest.java Outdated Show resolved Hide resolved
core/src/main/java/apoc/merge/Merge.java Outdated Show resolved Hide resolved
core/src/test/java/apoc/merge/MergeTest.java Show resolved Hide resolved
core/src/test/java/apoc/merge/MergeTest.java Outdated Show resolved Hide resolved
Lojjs
Lojjs approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine now

Lojjs
Lojjs approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine with the renaming too

@nadja-muller nadja-muller merged commit f94bc04 into dev Oct 12, 2023
14 checks passed
@nadja-muller nadja-muller deleted the merge-null-nodes branch October 12, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gem-neo4j gem-neo4j gem-neo4j left review comments

@Lojjs Lojjs Lojjs approved these changes

Assignees

@Lojjs Lojjs

Labels
dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nadja-muller @Lojjs @gem-neo4j