[hxmGFWvF] Only create a TriggerHandler if triggers are enabled. #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old code tried to put the expected error message in the help message place in assertThrows, leading to the tests passing even if there was another RuntimeException.
Lojjs
force-pushed
the
dev-no-triggerhandler-when-disabled
branch
2 times, most recently
from
f5b183f
to
2ace4f4
Compare
Lojjs
force-pushed
the
dev-no-triggerhandler-when-disabled
branch
from
2ace4f4
to
b46dddf
Compare
Lojjs
force-pushed
the
dev-no-triggerhandler-when-disabled
branch
from
ff32693
to
6ab73cd
Compare
Lojjs
force-pushed
the
dev-no-triggerhandler-when-disabled
branch
from
6ab73cd
to
4895d14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the TriggerHandler code, in particular the start() method was run even if triggers were disabled. This could cause issues in some edge cases as well as impact performance.
Also improve testing of disabled triggers.