Adding connection state to database side panel #226
Conversation
|
daveajrussell
changed the title
packages/vscode-extension/src/webviews/controllers/connectionPanelController.ts
Outdated
Show resolved
Hide resolved
daveajrussell
force-pushed
the
dajr/vscode-connection-panel
branch
from
7960884
to
19cfceb
Compare
daveajrussell
force-pushed
the
dajr/prototype-connection-state-simple
branch
from
550b84c
to
4a1fa54
Compare
There was a problem hiding this comment.
Changes in here support;
- prefilled inputs when adding a new connection
- refilling all possible inputs when editing a connection
- highlighting server invalidated fields on save
daveajrussell
changed the title
| ) { | ||
| _context = context; | ||
| _languageClient = languageClient; | ||
| _databaseConnectionManager = new SchemaPollerConnectionManager(); |
There was a problem hiding this comment.
@ncordon the vscode extension already has it's own driver instance here, you can create another one if you prefer, but I think it'd be nice to reuse this one as it's already got all the lifecycle (create, update, verify connectivity) set up
There was a problem hiding this comment.
Well this wasn't my point. This in fact means we already have two drivers at the moment: one on the VSCode side and one embedded in the language server
| ) { | ||
| _context = context; | ||
| _languageClient = languageClient; | ||
| _databaseConnectionManager = new SchemaPollerConnectionManager(); |
There was a problem hiding this comment.
Well this wasn't my point. This in fact means we already have two drivers at the moment: one on the VSCode side and one embedded in the language server
This PR introduces connection state to the database side panel.
At the moment, the side panel is fairly basic and will simply show a state for
connected, even if under the hood the connection has failed.In this change, the side panel becomes much smarter and hooks into newly emitting events from the underlying driver/database connection. The side panel will update itself when a database connection drops, when it reconnects and when it gives up trying to connect to the database.
Also introduced is instant connection status feedback when adding/editing/connecting to/toggling a Connection.. whether this is bad auth, a non existent database or an unreachable server.
In the side panel, when you connect to a connection you are first presented with a "Connecting" state.. the label next to the connection will briefly read
connecting...until the connection promise resolves, at which point we switch the label toconnectedand show a success info message.For connections that error (and are retriable), we will show a
reconnecting...label and an accompanying warning message.For connections that fail, we will remove the connecting state entirely and display an error message.