Skip to content

Commit

Permalink
Merge pull request #1675 from eijawerner/params-template
Browse files Browse the repository at this point in the history 
Params template
  • Loading branch information
@eijawerner
eijawerner committed Feb 11, 2022
2 parents 92de576 + df6eac3 commit be19d32
Show file tree
Hide file tree
Showing 26 changed files with 577 additions and 299 deletions.
8 changes: 8 additions & 0 deletions e2e_tests/integration/params.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -147,4 +147,12 @@ function runTests() {
'{\n "x": 1.0,\n "stringWithSpace": "with space",\n "stringWithTab": "\'with\ttab\'"\n}'
)
// })
// it('can generate a set params template to use if query is missing param', () => {
cy.executeCommand(':clear')
cy.executeCommand('return $test1, $test2')
const expectedMessage = `Expected parameter(s): test1, test2`
cy.get('[data-testid="cypherFrameErrorMessage"]', { timeout: 20000 })
.first()
.should('contain', expectedMessage)
// })
}
64 changes: 32 additions & 32 deletions src/browser/modules/Sidebar/__snapshots__/GuideDrawer.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ exports[`GuideDrawer renders guide slide when a guide is selected 1`] = `
data-testid="guidesBackButton"
>
<i
class="sc-fOKMvo gVZzMN"
class="sc-eilVRo gFBzhx"
>
<span
class="SVGInline SVGInline--cleaned"
Expand Down Expand Up @@ -81,7 +81,7 @@ exports[`GuideDrawer renders list view including Remote Guides list 1`] = `
</span>
in the code editor.
<div
class="sc-lkqHmb eiwGIl"
class="sc-krvtoX jZKaMc"
>
<div
class="sc-kEYyzF kpIobp"
Expand All @@ -90,10 +90,10 @@ exports[`GuideDrawer renders list view including Remote Guides list 1`] = `
</div>
</div>
<div
class="sc-gojNiO ikNDmz"
class="sc-lkqHmb jBjITi"
>
<li
class="sc-bXGyLb eUyJDI"
class="sc-cbkKFq ilCdUp"
data-testid="builtInGuideintro"
>
<span
Expand All @@ -103,15 +103,15 @@ exports[`GuideDrawer renders list view including Remote Guides list 1`] = `
intro
</span>
<div
class="sc-lkqHmb cSPHwa"
class="sc-krvtoX gDoQjI"
>
Navigating Neo4j Browser
</div>
</li>
<li
class="sc-bXGyLb eUyJDI"
class="sc-cbkKFq ilCdUp"
data-testid="builtInGuideconcepts"
>
<span
Expand All @@ -121,15 +121,15 @@ exports[`GuideDrawer renders list view including Remote Guides list 1`] = `
concepts
</span>
<div
class="sc-lkqHmb cSPHwa"
class="sc-krvtoX gDoQjI"
>
Property graph model concepts
</div>
</li>
<li
class="sc-bXGyLb eUyJDI"
class="sc-cbkKFq ilCdUp"
data-testid="builtInGuidecypher"
>
<span
Expand All @@ -139,15 +139,15 @@ exports[`GuideDrawer renders list view including Remote Guides list 1`] = `
cypher
</span>
<div
class="sc-lkqHmb cSPHwa"
class="sc-krvtoX gDoQjI"
>
Cypher basics - create, match, delete
</div>
</li>
<li
class="sc-bXGyLb eUyJDI"
class="sc-cbkKFq ilCdUp"
data-testid="builtInGuidemovie-graph"
>
<span
Expand All @@ -157,15 +157,15 @@ exports[`GuideDrawer renders list view including Remote Guides list 1`] = `
movie-graph
</span>
<div
class="sc-lkqHmb cSPHwa"
class="sc-krvtoX gDoQjI"
>
Queries and recommendations with Cypher - movie use case}
</div>
</li>
<li
class="sc-bXGyLb eUyJDI"
class="sc-cbkKFq ilCdUp"
data-testid="builtInGuidenorthwind-graph"
>
<span
Expand All @@ -175,7 +175,7 @@ exports[`GuideDrawer renders list view including Remote Guides list 1`] = `
northwind-graph
</span>
<div
class="sc-lkqHmb cSPHwa"
class="sc-krvtoX gDoQjI"
>
Translate and import relation data into graph
Expand All @@ -184,7 +184,7 @@ exports[`GuideDrawer renders list view including Remote Guides list 1`] = `
</li>
</div>
<div
class="sc-lkqHmb eiwGIl"
class="sc-krvtoX jZKaMc"
>
<div
class="sc-kEYyzF kpIobp"
Expand All @@ -194,10 +194,10 @@ exports[`GuideDrawer renders list view including Remote Guides list 1`] = `
</div>
</div>
<div
class="sc-gojNiO ikNDmz"
class="sc-lkqHmb jBjITi"
>
<li
class="sc-krvtoX HZOwu"
class="sc-dUjcNx SIWxf"
>
<span
class="sc-jWBwVP dpdnCs remove-play-icon"
Expand All @@ -206,17 +206,17 @@ exports[`GuideDrawer renders list view including Remote Guides list 1`] = `
Title
</span>
<span
class="sc-cbkKFq hwlbJw"
class="sc-fOKMvo clXrDz"
data-testid="removeGuideidentifier"
>
<i
class="sc-fYiAbW giXALH sl-bin"
class="sc-gHboQg cYpCNN sl-bin"
/>
</span>
</li>
</div>
<div
class="sc-eLExRp dvdOkB"
class="sc-fYiAbW jdVfDi"
>
<a
class="sc-cvbbAY iQWpYr"
Expand Down Expand Up @@ -261,7 +261,7 @@ exports[`GuideDrawer renders list view without Remote Guides 1`] = `
</span>
in the code editor.
<div
class="sc-lkqHmb eiwGIl"
class="sc-krvtoX jZKaMc"
>
<div
class="sc-kEYyzF kpIobp"
Expand All @@ -270,10 +270,10 @@ exports[`GuideDrawer renders list view without Remote Guides 1`] = `
</div>
</div>
<div
class="sc-gojNiO ikNDmz"
class="sc-lkqHmb jBjITi"
>
<li
class="sc-bXGyLb eUyJDI"
class="sc-cbkKFq ilCdUp"
data-testid="builtInGuideintro"
>
<span
Expand All @@ -283,15 +283,15 @@ exports[`GuideDrawer renders list view without Remote Guides 1`] = `
intro
</span>
<div
class="sc-lkqHmb cSPHwa"
class="sc-krvtoX gDoQjI"
>
Navigating Neo4j Browser
</div>
</li>
<li
class="sc-bXGyLb eUyJDI"
class="sc-cbkKFq ilCdUp"
data-testid="builtInGuideconcepts"
>
<span
Expand All @@ -301,15 +301,15 @@ exports[`GuideDrawer renders list view without Remote Guides 1`] = `
concepts
</span>
<div
class="sc-lkqHmb cSPHwa"
class="sc-krvtoX gDoQjI"
>
Property graph model concepts
</div>
</li>
<li
class="sc-bXGyLb eUyJDI"
class="sc-cbkKFq ilCdUp"
data-testid="builtInGuidecypher"
>
<span
Expand All @@ -319,15 +319,15 @@ exports[`GuideDrawer renders list view without Remote Guides 1`] = `
cypher
</span>
<div
class="sc-lkqHmb cSPHwa"
class="sc-krvtoX gDoQjI"
>
Cypher basics - create, match, delete
</div>
</li>
<li
class="sc-bXGyLb eUyJDI"
class="sc-cbkKFq ilCdUp"
data-testid="builtInGuidemovie-graph"
>
<span
Expand All @@ -337,15 +337,15 @@ exports[`GuideDrawer renders list view without Remote Guides 1`] = `
movie-graph
</span>
<div
class="sc-lkqHmb cSPHwa"
class="sc-krvtoX gDoQjI"
>
Queries and recommendations with Cypher - movie use case}
</div>
</li>
<li
class="sc-bXGyLb eUyJDI"
class="sc-cbkKFq ilCdUp"
data-testid="builtInGuidenorthwind-graph"
>
<span
Expand All @@ -355,7 +355,7 @@ exports[`GuideDrawer renders list view without Remote Guides 1`] = `
northwind-graph
</span>
<div
class="sc-lkqHmb cSPHwa"
class="sc-krvtoX gDoQjI"
>
Translate and import relation data into graph
Expand All @@ -364,7 +364,7 @@ exports[`GuideDrawer renders list view without Remote Guides 1`] = `
</li>
</div>
<div
class="sc-eLExRp dvdOkB"
class="sc-fYiAbW jdVfDi"
>
<a
class="sc-cvbbAY iQWpYr"
Expand Down
3 changes: 2 additions & 1 deletion src/browser/modules/Stream/CypherFrame/CypherFrame.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ import { SpinnerContainer, StyledStatsBarContainer } from '../styled'
import { AsciiStatusbar, AsciiView } from './AsciiView'
import { CancelView } from './CancelView'
import { CodeStatusbar, CodeView } from './CodeView'
import { ErrorsStatusbar, ErrorsView } from './ErrorsView'
import { ErrorsStatusbar } from './ErrorsView/ErrorsStatusbar'
import { ErrorsView } from './ErrorsView/ErrorsView'
import { PlanStatusbar, PlanView } from './PlanView'
import { VisualizationConnectedBus } from './VisualizationView'
import { WarningsStatusbar, WarningsView } from './WarningsView'
Expand Down

0 comments on commit be19d32

Please sign in to comment.