Params template on missing paramters errors #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eijawerner
force-pushed
the
params-template
branch
from
c95b96b
to
93d4d2a
Compare
as a preparation for splitting the file up into files for each subcomponent
eijawerner
force-pushed
the
params-template
branch
from
93d4d2a
to
19b52a8
Compare
src/browser/modules/Stream/CypherFrame/ErrorsView/ErrorsStatusbar.test.tsx
Show resolved
Hide resolved
src/browser/modules/Stream/CypherFrame/ErrorsView/ErrorsView.tsx
Outdated
Show resolved
Hide resolved
src/browser/modules/Stream/CypherFrame/ErrorsView/MissingParamsTemplateLink.tsx
Outdated
Show resolved
Hide resolved
and some cleanup
OskarDamkjaer
approved these changes
Feb 11, 2022
OskarDamkjaer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now can get help of adding missing parameters when receiving ParameterMissing error. User can click template link and fill the editor with code that can create the missing parameters (and is including all the existing ones, so they are not overwritten)
Will add unit and e2e test in follow up PR.
