Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Params template on missing paramters errors #1675

Merged
merged 7 commits into from
Feb 11, 2022
Merged

Params template on missing paramters errors #1675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e7f2d98
On missing params error can generate template
eijawerner Feb 7, 2022
31d59bc
Move ErrorsView into its own folder
eijawerner Feb 11, 2022
ee5966a
Split up ErrorsView file into one for each component
eijawerner Feb 11, 2022
a1b4bd5
Fixed the looks of the template when no existing params
eijawerner Feb 11, 2022
19b52a8
Update snapshot
eijawerner Feb 11, 2022
aabc636
Add metrics for 'set-missing-params-template'
eijawerner Feb 11, 2022
df6eac3
Review fixes
eijawerner Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions e2e_tests/integration/params.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,4 +147,12 @@ function runTests() {
'{\n "x": 1.0,\n "stringWithSpace": "with space",\n "stringWithTab": "\'with\ttab\'"\n}'
)
// })
// it('can generate a set params template to use if query is missing param', () => {
cy.executeCommand(':clear')
cy.executeCommand('return $test1, $test2')
const expectedMessage = `Expected parameter(s): test1, test2`
cy.get('[data-testid="cypherFrameErrorMessage"]', { timeout: 20000 })
.first()
.should('contain', expectedMessage)
// })
}
64 changes: 32 additions & 32 deletions src/browser/modules/Sidebar/__snapshots__/GuideDrawer.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ exports[`GuideDrawer renders guide slide when a guide is selected 1`] = `
data-testid="guidesBackButton"
>
<i
class="sc-fOKMvo gVZzMN"
class="sc-eilVRo gFBzhx"
>
<span
class="SVGInline SVGInline--cleaned"
Expand Down Expand Up @@ -81,7 +81,7 @@ exports[`GuideDrawer renders list view including Remote Guides list 1`] = `
</span>
in the code editor.
<div
class="sc-lkqHmb eiwGIl"
class="sc-krvtoX jZKaMc"
>
<div
class="sc-kEYyzF kpIobp"
Expand All @@ -90,10 +90,10 @@ exports[`GuideDrawer renders list view including Remote Guides list 1`] = `
</div>
</div>
<div
class="sc-gojNiO ikNDmz"
class="sc-lkqHmb jBjITi"
>
<li
class="sc-bXGyLb eUyJDI"
class="sc-cbkKFq ilCdUp"
data-testid="builtInGuideintro"
>
<span
Expand All @@ -103,15 +103,15 @@ exports[`GuideDrawer renders list view including Remote Guides list 1`] = `
intro
</span>
<div
class="sc-lkqHmb cSPHwa"
class="sc-krvtoX gDoQjI"
>

Navigating Neo4j Browser

</div>
</li>
<li
class="sc-bXGyLb eUyJDI"
class="sc-cbkKFq ilCdUp"
data-testid="builtInGuideconcepts"
>
<span
Expand All @@ -121,15 +121,15 @@ exports[`GuideDrawer renders list view including Remote Guides list 1`] = `
concepts
</span>
<div
class="sc-lkqHmb cSPHwa"
class="sc-krvtoX gDoQjI"
>

Property graph model concepts

</div>
</li>
<li
class="sc-bXGyLb eUyJDI"
class="sc-cbkKFq ilCdUp"
data-testid="builtInGuidecypher"
>
<span
Expand All @@ -139,15 +139,15 @@ exports[`GuideDrawer renders list view including Remote Guides list 1`] = `
cypher
</span>
<div
class="sc-lkqHmb cSPHwa"
class="sc-krvtoX gDoQjI"
>

Cypher basics - create, match, delete

</div>
</li>
<li
class="sc-bXGyLb eUyJDI"
class="sc-cbkKFq ilCdUp"
data-testid="builtInGuidemovie-graph"
>
<span
Expand All @@ -157,15 +157,15 @@ exports[`GuideDrawer renders list view including Remote Guides list 1`] = `
movie-graph
</span>
<div
class="sc-lkqHmb cSPHwa"
class="sc-krvtoX gDoQjI"
>

Queries and recommendations with Cypher - movie use case}

</div>
</li>
<li
class="sc-bXGyLb eUyJDI"
class="sc-cbkKFq ilCdUp"
data-testid="builtInGuidenorthwind-graph"
>
<span
Expand All @@ -175,7 +175,7 @@ exports[`GuideDrawer renders list view including Remote Guides list 1`] = `
northwind-graph
</span>
<div
class="sc-lkqHmb cSPHwa"
class="sc-krvtoX gDoQjI"
>

Translate and import relation data into graph
Expand All @@ -184,7 +184,7 @@ exports[`GuideDrawer renders list view including Remote Guides list 1`] = `
</li>
</div>
<div
class="sc-lkqHmb eiwGIl"
class="sc-krvtoX jZKaMc"
>
<div
class="sc-kEYyzF kpIobp"
Expand All @@ -194,10 +194,10 @@ exports[`GuideDrawer renders list view including Remote Guides list 1`] = `
</div>
</div>
<div
class="sc-gojNiO ikNDmz"
class="sc-lkqHmb jBjITi"
>
<li
class="sc-krvtoX HZOwu"
class="sc-dUjcNx SIWxf"
>
<span
class="sc-jWBwVP dpdnCs remove-play-icon"
Expand All @@ -206,17 +206,17 @@ exports[`GuideDrawer renders list view including Remote Guides list 1`] = `
Title
</span>
<span
class="sc-cbkKFq hwlbJw"
class="sc-fOKMvo clXrDz"
data-testid="removeGuideidentifier"
>
<i
class="sc-fYiAbW giXALH sl-bin"
class="sc-gHboQg cYpCNN sl-bin"
/>
</span>
</li>
</div>
<div
class="sc-eLExRp dvdOkB"
class="sc-fYiAbW jdVfDi"
>
<a
class="sc-cvbbAY iQWpYr"
Expand Down Expand Up @@ -261,7 +261,7 @@ exports[`GuideDrawer renders list view without Remote Guides 1`] = `
</span>
in the code editor.
<div
class="sc-lkqHmb eiwGIl"
class="sc-krvtoX jZKaMc"
>
<div
class="sc-kEYyzF kpIobp"
Expand All @@ -270,10 +270,10 @@ exports[`GuideDrawer renders list view without Remote Guides 1`] = `
</div>
</div>
<div
class="sc-gojNiO ikNDmz"
class="sc-lkqHmb jBjITi"
>
<li
class="sc-bXGyLb eUyJDI"
class="sc-cbkKFq ilCdUp"
data-testid="builtInGuideintro"
>
<span
Expand All @@ -283,15 +283,15 @@ exports[`GuideDrawer renders list view without Remote Guides 1`] = `
intro
</span>
<div
class="sc-lkqHmb cSPHwa"
class="sc-krvtoX gDoQjI"
>

Navigating Neo4j Browser

</div>
</li>
<li
class="sc-bXGyLb eUyJDI"
class="sc-cbkKFq ilCdUp"
data-testid="builtInGuideconcepts"
>
<span
Expand All @@ -301,15 +301,15 @@ exports[`GuideDrawer renders list view without Remote Guides 1`] = `
concepts
</span>
<div
class="sc-lkqHmb cSPHwa"
class="sc-krvtoX gDoQjI"
>

Property graph model concepts

</div>
</li>
<li
class="sc-bXGyLb eUyJDI"
class="sc-cbkKFq ilCdUp"
data-testid="builtInGuidecypher"
>
<span
Expand All @@ -319,15 +319,15 @@ exports[`GuideDrawer renders list view without Remote Guides 1`] = `
cypher
</span>
<div
class="sc-lkqHmb cSPHwa"
class="sc-krvtoX gDoQjI"
>

Cypher basics - create, match, delete

</div>
</li>
<li
class="sc-bXGyLb eUyJDI"
class="sc-cbkKFq ilCdUp"
data-testid="builtInGuidemovie-graph"
>
<span
Expand All @@ -337,15 +337,15 @@ exports[`GuideDrawer renders list view without Remote Guides 1`] = `
movie-graph
</span>
<div
class="sc-lkqHmb cSPHwa"
class="sc-krvtoX gDoQjI"
>

Queries and recommendations with Cypher - movie use case}

</div>
</li>
<li
class="sc-bXGyLb eUyJDI"
class="sc-cbkKFq ilCdUp"
data-testid="builtInGuidenorthwind-graph"
>
<span
Expand All @@ -355,7 +355,7 @@ exports[`GuideDrawer renders list view without Remote Guides 1`] = `
northwind-graph
</span>
<div
class="sc-lkqHmb cSPHwa"
class="sc-krvtoX gDoQjI"
>

Translate and import relation data into graph
Expand All @@ -364,7 +364,7 @@ exports[`GuideDrawer renders list view without Remote Guides 1`] = `
</li>
</div>
<div
class="sc-eLExRp dvdOkB"
class="sc-fYiAbW jdVfDi"
>
<a
class="sc-cvbbAY iQWpYr"
Expand Down
3 changes: 2 additions & 1 deletion src/browser/modules/Stream/CypherFrame/CypherFrame.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ import { SpinnerContainer, StyledStatsBarContainer } from '../styled'
import { AsciiStatusbar, AsciiView } from './AsciiView'
import { CancelView } from './CancelView'
import { CodeStatusbar, CodeView } from './CodeView'
import { ErrorsStatusbar, ErrorsView } from './ErrorsView'
import { ErrorsStatusbar } from './ErrorsView/ErrorsStatusbar'
import { ErrorsView } from './ErrorsView/ErrorsView'
import { PlanStatusbar, PlanView } from './PlanView'
import { VisualizationConnectedBus } from './VisualizationView'
import { WarningsStatusbar, WarningsView } from './WarningsView'
Expand Down