Improve tests & result builder classes #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ali-ince
commented
Jul 3, 2017
ali-ince
commented
- Added tests for Session#RunAsync, Session#BeginTransactionAsync and Session#Dispose after async calls,
- Added tests for Transaction#RunAsync,
- Improved ResultBuilder & ResultReaderBuilder with a new base class including common members from both classes,
- Added tests for ResultReaderBuilder & StatementResultReader,
- Added Session#BeginTransactionAsync(string bookmark) method.
1. Added tests for Session#RunAsync, Session#BeginTransactionAsync and Session#Dispose after async calls, 2. Added tests for Transaction#RunAsync, 3. Improved ResultBuilder & ResultReaderBuilder with a new base class including common members from both classes, 4. Added tests for ResultReaderBuilder & StatementResultReader, 5. Added Session#BeginTransactionAsync(string bookmark) method.
zhenlineo
reviewed
Jul 4, 2017
| @@ -427,6 +427,13 @@ public Task<ITransactionAsync> BeginTransactionAsync() | |||
| return TryExecuteAsync(async()=> await BeginTransactionWithoutLoggingAsync(_defaultMode)); | |||
| } | |||
|
|
|||
| public Task<ITransactionAsync> BeginTransactionAsync(string bookmark) | |||
There was a problem hiding this comment.
There should be no BeginTx with bookmark as it is deprecated method already
| @@ -23,23 +23,20 @@ | |||
|
|
|||
| namespace Neo4j.Driver.Internal.Result | |||
| { | |||
| internal class ResultReaderBuilder : IMessageResponseCollector | |||
| internal class ResultReaderBuilder : BuilderBase | |||
There was a problem hiding this comment.
Is it easy to break the logic of IMessageResponseCollector to an independent class such as MessageResponseCollector and have an field in this class instead?
Suggesting to change in another PR if agreed.
| @@ -85,7 +82,7 @@ public IStatementResultReader PreBuild() | |||
| return _records.Count > 0 ? _records.Dequeue() : null; | |||
| } | |||
|
|
|||
| private void SetReceiveOneFunc(Func<Task> receiveOneAction) | |||
| internal void SetReceiveOneAction(Func<Task> receiveOneAction) | |||
There was a problem hiding this comment.
About naming:
It is actually a function, so suggesting to name this to SetReceiveOneFunc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.