Changed the impl for waiting for keys to arrive #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed quickly now :P |
added 2 commits
September 22, 2017 13:21
For sync, the key will be received when result.Keys method is called. The method will block there until the key arrives via the reply of Run message For async, the key will be received when a result cursor is built. While returning cursor after Run method, we will wait there for the reply of Run message
zhenlineo
force-pushed
the
1.5-receive-run-reply
branch
from
f67157b
to
1677e8a
Compare
ali-ince
approved these changes
Sep 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For sync, the key will be received when
result.Keysmethod is called. The method will block there until the key arrives via the reply ofRunmessageFor async, the key will be received when a result cursor is built. While returning cursor after
Runmethod, we will wait there for the reply ofRunmessage