Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve identity handling and allow custom id generation #344

Closed
nmervaillie opened this issue Mar 28, 2017 · 0 comments
Closed

Improve identity handling and allow custom id generation #344

nmervaillie opened this issue Mar 28, 2017 · 0 comments
Assignees
@nmervaillie
Labels
improvement

Comments

@nmervaillie
Copy link
Member

All objects must define the internal Neo4j ID, either using the Long id semantic in their models or annotating it with @GraphID. This id must always be long and must never be set by the user. In fact it should probably not be exposed at all in this manner at all as it has led to a lot of confusion and misunderstanding. This is further compounded in SDN where repositories allow users to define their own ID’s and then provide several support methods around querying, saving, deleting etc. SD Repositories intend to allow developers to define their own Ids including their types.

To be clear, it’s fine that the Long id can be used as an ID but it shouldn’t be the only mechanism and certainly not always tied to being a Long in the context of an ID.
nmervaillie added a commit that referenced this issue Mar 28, 2017
@nmervaillie
Improve identity handling and allow custom id generation (introduce n…
b2caf41 
…ew annotations @id and @generated). #344.
@nmervaillie nmervaillie self-assigned this Apr 5, 2017
nmervaillie added a commit that referenced this issue Apr 12, 2017
@nmervaillie
#344 - Improve identity handling and allow custom id generation
26ecbc9 
Reduce coupling on native long IDs in the mapping context
nmervaillie added a commit that referenced this issue Apr 20, 2017
@nmervaillie
#344 - Improve identity handling and allow custom id generation
9c829e0 
Reduce coupling on native long IDs in the mapping context
Add javadoc
Introduce wrapping entities with holder containing native graph id
nmervaillie added a commit that referenced this issue Apr 20, 2017
@nmervaillie
#344 - Improve identity handling and allow custom id generation
7a5c1e8 
WIP - some bits working
nmervaillie added a commit that referenced this issue Apr 20, 2017
@nmervaillie
#344 - Improve identity handling and allow custom id generation
fedd3cf 
more decoupling on ids
nmervaillie added a commit that referenced this issue Apr 20, 2017
@nmervaillie
#344 - Improve identity handling and allow custom id generation
547787b 
Add scanning of @id annotations
nmervaillie added a commit that referenced this issue Apr 28, 2017
@nmervaillie
#344 - Improve identity handling and allow custom id generation
9ed3274 
Introduce scanning of @id and @GeneratedValue annotations
Implement UUID generation strategy
Has to be completed to make @GraphID optional and implement Native Neo4j id generation
nmervaillie added a commit to nmervaillie/neo4j-ogm that referenced this issue May 31, 2017
@nmervaillie
neo4j#344 - Improve identity handling and allow custom id generation
8e68b5f 
Add test for @id inheritance support
nmervaillie added a commit to nmervaillie/neo4j-ogm that referenced this issue May 31, 2017
@nmervaillie
neo4j#344 - Improve identity handling and allow custom id generation
b17c272 
Use Object type as node identifiers instead of Longs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmervaillie nmervaillie

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nmervaillie