Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shade ASM library to avoid version conflicts in embedded deployments #10128

Merged
merged 1 commit into from
Sep 29, 2017
Merged

Shade ASM library to avoid version conflicts in embedded deployments #10128

merged 1 commit into from
Sep 29, 2017

Conversation

chrisvest
Copy link
Contributor

No description provided.

Copy link
Contributor

@fickludd fickludd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't double check that this does indeed hide org.objectweb.asm, but I guess you did :).

@fickludd
Copy link
Contributor

Tests are flaky, cardified fixing those, and muted in TC. Will merge this on freeze manager approval.

@chrisvest chrisvest changed the title Shade ASM to avoid conflicts in embedded deployments Shade ASM library to avoid version conflicts in embedded deployments Sep 27, 2017
@systay systay merged commit 07839d8 into neo4j:3.2 Sep 29, 2017
@chrisvest chrisvest deleted the 3.2-shade-asm branch September 29, 2017 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants