Ability to concatenate arbitrary lists. Fixes #10021 #10270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigtaverner
approved these changes
Oct 20, 2017
Also fix reverse type in sematic checking.
craigtaverner
added a commit
that referenced
this pull request
Nov 7, 2017
Forward merge of #10270 to 3.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix reverse type in sematic checking.
Previously, the semantic checking did not allow concatenating mixed typed lists (and scalars). This PR fixes that.
changelog: Fixes #10021 so that we can concatenate and reverse lists of mixed types