Make query result push rows to the server response #4345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -227,15 +227,17 @@ | |||
| /** | |||
| * This is the visitor interface you need to implement to use the {@link Result#accept(ResultVisitor)} method. | |||
| */ | |||
| interface ResultVisitor | |||
| interface ResultVisitor<VisitationException extends Exception> | |||
There was a problem hiding this comment.
Could we have something like
interface ResultsVisitor<E> extends org.neo4j.helpers.collection.Visitor<Result.ResultRow, E>
instead?
There was a problem hiding this comment.
I'd prefer not. It would be nice if we could treat the org.neo4j.helpers package as internal and not expose it in the API.
thobe
force-pushed
the
2.3-push-to-server
branch
from
a7ee4f7
to
02effe1
Compare
thobe
force-pushed
the
2.3-push-to-server
branch
from
02effe1
to
90e0a7a
Compare
| @@ -22,35 +22,21 @@ package org.neo4j.cypher.internal.compiler.v2_3.birk.il | |||
| import org.neo4j.graphdb.Direction | |||
|
|
|||
| case class ExpandC(fromVar: String, relVar: String, dir: Direction, types: Map[String, String], toVar: String, inner: Instruction) extends LoopDataGenerator { | |||
| private val visitMethod = | |||
| private val theBody = | |||
There was a problem hiding this comment.
I really the changes in this file, but I believe it might not really belong in this commit, right?
There was a problem hiding this comment.
It was required to make the tests pass...
I thought of putting in a separate commit in the same PR, but decided against it since it would have made the first commit useless on its own.
systay
added a commit
that referenced
this pull request
Apr 2, 2015
Make query result push rows to the server response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.