Fix return * with order by leaking internal variable names #8389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RETURN * with ORDER BY should not leak internal variable names in the final result due to AST rewriting.
NormalizeReturnClauses adds a field about which columns are for internal use only, but these were not removed in later rewrites. This made it difficult to write tests, since parsing a query would never produce any values for the internal only RETURN clause field. This change restores the AST after rewriting, so tests are easy to write.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog:
RETURN *withORDER BYshould not leak internal variable names in the final result due to AST rewriting.