Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return * with order by leaking internal variable names #8389

Merged
merged 2 commits into from Nov 21, 2016
Merged

Fix return * with order by leaking internal variable names #8389

merged 2 commits into from Nov 21, 2016

Commits on Nov 17, 2016

  1. Fix return * with order by leaking internal variable names 

    RETURN * with ORDER BY should not leak internal variable names in the final
result due to AST rewriting.
    @henriknyman
    henriknyman committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    5af6ee7 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2016

  1. Clean up RETURN clause after rewriting 

    NormalizeReturnClauses adds a field about which columns are for internal use only,
but these were not removed in later rewrites. This made it difficult to write tests,
since parsing a query would never produce any values for the internal only RETURN
clause field.

This change restores the AST after rewriting, so tests are easy to write.
    @systay
    systay committed Nov 18, 2016
    Configuration menu
    Copy the full SHA
    2b21861 View commit details
    Browse the repository at this point in the history